Fix interactive tool selection in quarto install/update/uninstall#13935
Merged
Fix interactive tool selection in quarto install/update/uninstall#13935
Conversation
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Collaborator
Author
|
Building 'quarto.exe' for this branch: https://github.com/quarto-dev/quarto-cli/actions/runs/21256479552 Because it seems that cliffy in dev version does not work well - I can't select choices in the list with the arrow 🤷 |
Collaborator
Author
|
Tested locally that this works as expected now. Glad we found it at last !! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running
quarto install,quarto update, orquarto uninstallwithout arguments, the interactive tool selector shows the list but the selection always returnsundefined.Root Cause
Same issue as #9765 - Cliffy's
Select.prompt()returns the selected value directly, but the code incorrectly accesses.valueon the result.Fix
Use the
prompt()array syntax with a named field, same pattern as #9765.