Google OAuth2 authentication for Quarto Hub#18
Open
shikokuchuo wants to merge 17 commits intomainfrom
Open
Conversation
e4f1478 to
41af226
Compare
3114cdc to
1c0b698
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds optional Google Sign-In across the Hub server and and web client.
Auth is off by default and enabled by passing
--google-client-id <ID>to the hub server.Architecture
Auth is enforced at the transport layer (HTTP/WebSocket upgrade) before any request processing begins.
The sync protocol (samod/Automerge) is completely unaware of authentication — unauthenticated connections are rejected before they reach it. This keeps auth concerns out of the collaboration engine entirely.
Server (quarto-hub)
/health,/api/*, and WebSocket sync) require a valid token when auth is enabled.--allowed-emailsand--allowed-domains.QUARTO_HUB_GOOGLE_CLIENT_ID,QUARTO_HUB_ALLOWED_EMAILSandQUARTO_HUB_ALLOWED_DOMAINSallowed in place of arguments.Web client (hub-client)
button.