feat(input): history recall via Up/Down + /history command (port upstream PR #265)#307
Merged
Conversation
- Add input_history ring buffer (max 100) and input_history_index to App - Up arrow in empty input recalls previous submitted inputs - Down arrow navigates forward through history, clearing at the end - Any manual edit (typing, backspace) cancels history browsing - Consecutive duplicate inputs are not stored - /history lists all stored inputs with indices - /history input N loads entry N into the input box - Works in both local and remote TUI modes - Help overlay updated with new keybindings and /history command - 13 unit tests covering all history operations Closes #264
…overage - Up arrow now works when already browsing history (not just from empty input) - Same fix applied to both local and remote key handlers - reset_input_history_browse added to insert_input_text, undo_input_change, and remember_input_undo_state for comprehensive coverage - Removed redundant reset calls from individual key handlers - Added tests for multi-press Up navigation, Down when not browsing - 15 total tests passing
… indicator - /history clear: wipe all entries - /history search <term>: case-insensitive search with match count - /history delete N: remove specific entry - Non-consecutive dedup: re-inserting existing text moves it to the end - Persistent history: saved to ~/.jcode/input-history.json, loaded on startup - Status bar indicator: shows '📋 history N/M' while browsing - input_history_browse_status() added to TuiState trait - 20 unit tests passing (7 new)
…/history input N Round 1: save_input_history now deletes file when history is empty so /clear doesn't leave stale data on disk. Round 2: Update help overlay, autocomplete description, and add /history to command_accepts_args. Remove duplicate inherent input_history_browse_status method in favor of trait impl. Round 3: Better error messages for /history delete and /history input when history is empty. Add catch-all for unknown /history subcommands. Remove double clone. Round 4: Add missing sync_model_picker_preview_from_input() call on /history input N. Round 5: Save undo state before /history input N replaces input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of upstream PR 1jehuang/jcode#265 (open). Adds input history recall — submitted inputs are remembered across the session so the user can press Up/Down to recall prior submissions.
What ships
<JCODE_HOME>/input_history.tomlConflict resolution
src/tui/app/input.rs: kept fork's prompt template expansion (PR Prompt templates: reusable Markdown prompts invoked via/name#4) + added upstream'spush_input_historycall after expansion so the recall menu shows user-typed string, not expanded body.Tests
5 cherry-picked commits include the upstream test coverage:
Refs upstream PR 1jehuang/jcode#265.