Repository navigation
Enable prefill_q, prefill_kv, prefill_qkv blocking with weightfree/dynamo - #1456
Abhishek Kumar Singh (abhishek-singh591) wants to merge 18 commits into
Conversation
Signed-off-by: Abhishek kumar singh <sabhis@qti.qualcomm.com>
Signed-off-by: Abhishek kumar singh <sabhis@qti.qualcomm.com>
Onkar Chougule (ochougul)
left a comment
There was a problem hiding this comment.
The new softmax argument ordering introduces a runtime/export regression in existing positional callers. CI is still pending; git diff --check passes.
Signed-off-by: Abhishek kumar singh <sabhis@qti.qualcomm.com>
Signed-off-by: Abhishek kumar singh <sabhis@qti.qualcomm.com>
Ann Kuruvilla (quic-akuruvil)
left a comment
There was a problem hiding this comment.
please check the failure on unit tests
Ann Kuruvilla (quic-akuruvil)
left a comment
There was a problem hiding this comment.
how many additional tests have been added in WF stage?
Onkar Chougule (ochougul)
left a comment
There was a problem hiding this comment.
The attention, cache handoff, and dispatch changes line up on the pinned head. The offline KV/QKV export assertions are unreachable, as noted inline. GitHub reports only DCO as passing; I did not run the QAIC matrix locally.
Signed-off-by: Abhishek kumar singh <sabhis@qti.qualcomm.com>
e0afeac to
1d446d4
Compare
…mers into weight_free_prefill Signed-off-by: Abhishek kumar singh <sabhis@qti.qualcomm.com> # Conflicts: # QEfficient/blocking/attention_blocking.py
|
Follow-up after syncing upstream main in commit
All inline review threads are resolved. The older formal review still leaves GitHub at |
Signed-off-by: Abhishek Kumar Singh <sabhis@qti.qualcomm.com>
Blocking-Mode Generation ResultsFull-model QAIC runs for Qwen3-VL-MoE 30B, Qwen3.5-MoE 35B-A3B, GPT-OSS 20B, and Gemma 4 E2B. This summarizes the retained result JSON/QEff logs as of November 5, 2026. Missing or cleaned artifacts are called out rather than treated as passing inference. Configuration at a Glance
Blocking parameters used by the VLM runs:
The GPT-OSS parity script uses the same Q/K/KV block settings, with ResultsQwen3-VL-MoE 30B
Qwen3.5-MoE 35B-A3B
GPT-OSS 20B
Gemma 4 E2B
|
Signed-off-by: Abhishek kumar singh <sabhis@qti.qualcomm.com>
Signed-off-by: Abhishek kumar singh <sabhis@qti.qualcomm.com>
|
CI-Ready |
Signed-off-by: Abhishek Kumar Singh <sabhis@qti.qualcomm.com>
Signed-off-by: Abhishek kumar singh <sabhis@qti.qualcomm.com>
Signed-off-by: Abhishek kumar singh <sabhis@qti.qualcomm.com> # Conflicts: # tests/weight_free/test_on_qaic_vlm.py
Signed-off-by: Abhishek kumar singh <sabhis@qti.qualcomm.com>
Signed-off-by: Abhishek kumar singh <sabhis@qti.qualcomm.com>
Signed-off-by: Abhishek kumar singh <sabhis@qti.qualcomm.com>
Weight-Free Offline Prefill Blocking
Summary
This branch adds and validates offline weight-free prefill blocking across
GPT-OSS, Gemma4, Qwen3-VL-MoE, and Qwen3.5-MoE. It covers the
prefill_q,prefill_kv, andprefill_qkvmodes through export, compile, QAIC runtime,and HF token-parity tests.
Branch Changes
parity coverage for supported causal-LM and VLM paths.
blocked-cache access required by the compiled graph.
regression coverage for the new modes.
usage documentation.
weight-free blocking test suite.
Gemma4 Correction
The Gemma4 follow-up restores the layer-specific bidirectional vision-mask
behavior:
sliding_attention;ctx_lenas its target length only forprefill_online;skip_kv=Falsefor that mask path; andseq_len, notctx_len, including the non-degenerate decode trace.Focused tests cover prompt and decode dummy-cache shapes, and the existing
weight-free Gemma4 decode export test verifies the contract when
ctx_lenisprovided.
Validation
The complete QAIC parity matrix passes after retrying one transient
QAIC_ERROR_NSP_ALLOC_FAILEDdevice-allocation failure:prefill_qprefill_kvprefill_qkv