Skip to content

firmware-qcom-boot-Kaanapali: Add boot firmware recipe #1762

Merged
ricardosalveti merged 3 commits intoqualcomm-linux:masterfrom
apaigava:kaanapali-meta-qcom
Apr 8, 2026
Merged

firmware-qcom-boot-Kaanapali: Add boot firmware recipe #1762
ricardosalveti merged 3 commits intoqualcomm-linux:masterfrom
apaigava:kaanapali-meta-qcom

Conversation

@apaigava
Copy link
Copy Markdown
Contributor

@apaigava apaigava commented Mar 16, 2026

Add boot firmware support for Kaanapali-MTP and updating the machine configuration.
Switch the board to use systemd-boot and remove the ABL_SIGNATURE_VERSION definition, as abl2esp.elf is no longer required.

@ricardosalveti
Copy link
Copy Markdown
Contributor

Why did you create a new pull-request instead of updating #1760?

@lumag lumag closed this Mar 16, 2026
@lumag lumag reopened this Mar 16, 2026
@lumag
Copy link
Copy Markdown
Contributor

lumag commented Mar 16, 2026

Argh. Stop deleting old forks. Who suggested this pattern?

@vkraleti @sbanerjee-quic This is yet another unobvious way our engineers use to close old pull requests (the first one was to push an empty branch). If our engineer can't use Git properly, I don't want to see their contributions in meta-qcom. It takes more time to point out Git usage erros than to review the PR.

As I'm already ranting, please include people who don't know how to use git commit -s into the rant. Or engineers who skip setting up the Git config and so end up contributing using their login name instead of the full name. Or all other similar errors.

@apaigava
Copy link
Copy Markdown
Contributor Author

Hi,
Sorry about the inconvenience. This is our team’s first time handling PRs, and I’m still getting familiar with GitHub. I’ll be more careful going forward.

Comment thread recipes-bsp/firmware-boot/firmware-qcom-boot-kaanapali.inc Outdated
Comment thread recipes-bsp/firmware-boot/firmware-qcom-boot-kaanapali_00009.1.bb Outdated
Comment thread conf/machine/kaanapali-mtp.conf Outdated
@ricardosalveti
Copy link
Copy Markdown
Contributor

firmware-qcom-boot-Kaanapali -> firmware-qcom-boot-kaanapali, this is the actual name of the recipe.

Please break your commit message in multiple lines, wrap at 72 characters per line.

@apaigava apaigava force-pushed the kaanapali-meta-qcom branch from d045578 to f070f33 Compare March 17, 2026 11:52
Comment thread recipes-bsp/firmware-boot/firmware-qcom-boot-kaanapali.inc
Comment thread conf/machine/kaanapali-mtp.conf
Comment thread conf/machine/kaanapali-mtp.conf
@apaigava apaigava force-pushed the kaanapali-meta-qcom branch 2 times, most recently from 323214f to c7ba8e5 Compare March 23, 2026 06:31
Comment thread conf/machine/kaanapali-mtp.conf
@apaigava apaigava force-pushed the kaanapali-meta-qcom branch from c7ba8e5 to 85cb6ac Compare March 24, 2026 06:05
Comment thread conf/machine/kaanapali-mtp.conf
@apaigava apaigava force-pushed the kaanapali-meta-qcom branch from 85cb6ac to 5453b2d Compare March 24, 2026 10:05
@ricardosalveti
Copy link
Copy Markdown
Contributor

Please rebase to fix the CI issues.

@apaigava apaigava force-pushed the kaanapali-meta-qcom branch from 5453b2d to 42a2d97 Compare March 27, 2026 04:01
@apaigava
Copy link
Copy Markdown
Contributor Author

Hi @ricardosalveti,
Updated.

Copy link
Copy Markdown
Contributor

@lumag lumag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2026-03-27 04:10:29 - ERROR    - ERROR: firmware-qcom-boot-kaanapali-00009.1-r0 do_fetch: Fetcher failure for URL: 'https://softwarecenter.qualcomm.com/nexus/generic/product/chip/software-product-family/Qualcomm_Linux.SPF.0.0/qualcomm_linux.spf.0.0-test-device-public/r0.0_00009.1/KAANAPALI.LE.0.0/common/build/ufs/bin/kaanapali_bootbinaries.zip;downloadfilename=kaanapali_bootbinaries_r0.0_00009.1.zip;name=bootbinaries'. Checksum mismatch!
2026-03-27 04:10:29 - ERROR    - File: '/downloads/kaanapali_bootbinaries_r0.0_00009.1.zip.tmp' has sha256 checksum '87b72830fd06ffd08ebc211301a254f4ef46325fde75bb6ff82ac558a5c26b12' when '87B72830FD06FFD08EBC211301A254F4EF46325FDE75BB6FF82AC558A5C26B12' was expected

@apaigava
Copy link
Copy Markdown
Contributor Author

Hi @lumag,
The sha256 checksum values are the identical,
Could you please clarify what changes are expected from my side for this issue?

@koenkooi
Copy link
Copy Markdown
Contributor

Hi @lumag, The sha256 checksum values are the identical

The string isn't, you have listed in in uppercase, but the checksum is compared against the lowercase value as a regular string compare. This is why stray whitespace will also make it fail.

, Could you please clarify what changes are expected from my side for this issue?

Change all checksums to their expected casing.

@apaigava
Copy link
Copy Markdown
Contributor Author

apaigava commented Apr 2, 2026

Hi, the branch has been rebased.

@quaresmajose
Copy link
Copy Markdown
Contributor

2026-04-02 05:57:28 - ERROR    - ERROR: qcom-multimedia-image-1.0-r0 do_populate_lic_deploy: Some packages cannot be installed into the image because they have incompatible licenses:
2026-04-02 05:57:28 - ERROR    - firmware-qcom-boot-kaanapali (LICENSE.qcom-2)
2026-04-02 05:57:28 - ERROR    - ERROR: Logfile of failure stored in: /work/build/tmp/work/kaanapali_mtp-qcom-linux/qcom-multimedia-image/1.0/temp/log.do_populate_lic_deploy.166469
2026-04-02 05:57:28 - INFO     - NOTE: recipe qcom-multimedia-image-1.0-r0: task do_populate_lic_deploy: Failed
2026-04-02 05:57:28 - ERROR    - ERROR: Task (/work/build/../meta-qcom-distro/recipes-products/images/qcom-multimedia-image.bb:do_populate_lic_deploy) failed with exit code '1'

@quaresmajose
Copy link
Copy Markdown
Contributor

Your PR will require some changes on https://github.com/qualcomm-linux/meta-qcom-distro/blob/main/recipes-products/images/qcom-multimedia-image.bbappend. I'm going to propose a PR moving parts of this file from meta-qcom-distro to meta-qcom, and then you can add it here in the layer.

quaresmajose pushed a commit to quaresmajose/meta-qcom that referenced this pull request Apr 2, 2026
qcom-multimedia-image is expected to contain only the open-source
software (except for the components to be executed on the
non-main cores, e.g on Hexagon DSP).

Use INCOMPATIBLE_LICENSE to make sure that no closed-source software
can get into qcom-multimedia-image. The setting is performed in the
bbappend so that it doesn't affect other images which include
qcom-multimedia-image.bb (like the qcom-multimedia-proprietary-image).

Fixes qualcomm-linux#1762

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
(cherry picked from commit cc1db67)
qualcomm-linux/meta-qcom-distro@cc1db67
Signed-off-by: Jose Quaresma <jose.quaresma@oss.qualcomm.com>
quaresmajose pushed a commit to quaresmajose/meta-qcom that referenced this pull request Apr 2, 2026
Listing libvulkan-adreno1 in the BAD_RECOMMENDATIONS makes dnf ignore it
and thus pull in meta-vulkan-drivers as a virtual-vulkan-icd provider.
Drop unnecessary assignment pulling in meta-vulkan-drivers again.

Fixes qualcomm-linux#1762

Fixes: cc1db67c0174 ("qcom-multimedia-image: conflict with proprietary software")
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
(cherry picked from commit 7add89e)
qualcomm-linux/meta-qcom-distro@7add89e
Signed-off-by: Jose Quaresma <jose.quaresma@oss.qualcomm.com>
@quaresmajose
Copy link
Copy Markdown
Contributor

Please wait for #1864

@apaigava apaigava force-pushed the kaanapali-meta-qcom branch from 22fff7e to 96a296d Compare April 6, 2026 05:01
@apaigava
Copy link
Copy Markdown
Contributor Author

apaigava commented Apr 6, 2026

Hi @lumag,
can you check and approve if the PR looks good?

@quaresmajose
Copy link
Copy Markdown
Contributor

Please wait for #1864

Fixed with qualcomm-linux/meta-qcom-distro#257

quaresmajose
quaresmajose previously approved these changes Apr 6, 2026
lumag
lumag previously approved these changes Apr 6, 2026
Comment thread conf/machine/kaanapali-mtp.conf Outdated
qcom-fastcv-binaries-kaanapali-mtp-dsp \
"

QCOM_CDT_FILE = "cdt_kaanapali_mtp_0.4.0.bin"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 'cdt_kaanapali_mtp_0.4.0' only:

classes-recipe/image_types_qcom.bbclass: install -m 0644 ${DEPLOY_DIR_IMAGE}/${QCOM_BOOT_FILES_SUBDIR}/${QCOM_CDT_FILE}.bin cdt.bin

Copy link
Copy Markdown
Contributor

@ricardosalveti ricardosalveti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QCOM_CDT_FILE needs fixing.

Add a boot firmware recipe for Kaanapali-MTP board.

Signed-off-by: Arohi Paigavan <apaigava@qti.qualcomm.com>
Signed-off-by: Paigavan, Arohi <apaigava@qti.qualcomm.com>
@apaigava apaigava dismissed stale reviews from lumag and quaresmajose via fc95215 April 7, 2026 06:14
@apaigava apaigava force-pushed the kaanapali-meta-qcom branch from 96a296d to fc95215 Compare April 7, 2026 06:14
@apaigava
Copy link
Copy Markdown
Contributor Author

apaigava commented Apr 7, 2026

Hi @ricardosalveti ,
I have made the required change

@quaresmajose
Copy link
Copy Markdown
Contributor

Hi @ricardosalveti , I have made the required change

The ".bin" was removed on the last commit but it should be in the second.

apaigava added 2 commits April 7, 2026 15:12
Update the KAANAPALI-MTP machine configuration to add the boot firmware,
cdt and specify the paths of partition binaries to consume them in flat build.

Signed-off-by: Arohi Paigavan <apaigava@qti.qualcomm.com>
The updated boot firmware follows the standard UEFI boot flow, so ABL is
no longer used on Kaanapali-MTP.

Signed-off-by: Arohi Paigavan <apaigava@qti.qualcomm.com>
@apaigava apaigava force-pushed the kaanapali-meta-qcom branch from fc95215 to 87e1b16 Compare April 7, 2026 09:46
@apaigava
Copy link
Copy Markdown
Contributor Author

apaigava commented Apr 7, 2026

Hi @ricardosalveti , I have made the required change

The ".bin" was removed on the last commit but it should be in the second.
I’ve corrected it now

@lumag lumag requested a review from ricardosalveti April 7, 2026 12:15
@ricardosalveti ricardosalveti merged commit 1be0d26 into qualcomm-linux:master Apr 8, 2026
226 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants