firmware-qcom-boot-Kaanapali: Add boot firmware recipe #1762
firmware-qcom-boot-Kaanapali: Add boot firmware recipe #1762ricardosalveti merged 3 commits intoqualcomm-linux:masterfrom
Conversation
|
Why did you create a new pull-request instead of updating #1760? |
|
Argh. Stop deleting old forks. Who suggested this pattern? @vkraleti @sbanerjee-quic This is yet another unobvious way our engineers use to close old pull requests (the first one was to push an empty branch). If our engineer can't use Git properly, I don't want to see their contributions in meta-qcom. It takes more time to point out Git usage erros than to review the PR. As I'm already ranting, please include people who don't know how to use |
|
Hi, |
|
Please break your commit message in multiple lines, wrap at 72 characters per line. |
d045578 to
f070f33
Compare
323214f to
c7ba8e5
Compare
c7ba8e5 to
85cb6ac
Compare
85cb6ac to
5453b2d
Compare
|
Please rebase to fix the CI issues. |
5453b2d to
42a2d97
Compare
|
Hi @ricardosalveti, |
lumag
left a comment
There was a problem hiding this comment.
2026-03-27 04:10:29 - ERROR - ERROR: firmware-qcom-boot-kaanapali-00009.1-r0 do_fetch: Fetcher failure for URL: 'https://softwarecenter.qualcomm.com/nexus/generic/product/chip/software-product-family/Qualcomm_Linux.SPF.0.0/qualcomm_linux.spf.0.0-test-device-public/r0.0_00009.1/KAANAPALI.LE.0.0/common/build/ufs/bin/kaanapali_bootbinaries.zip;downloadfilename=kaanapali_bootbinaries_r0.0_00009.1.zip;name=bootbinaries'. Checksum mismatch!
2026-03-27 04:10:29 - ERROR - File: '/downloads/kaanapali_bootbinaries_r0.0_00009.1.zip.tmp' has sha256 checksum '87b72830fd06ffd08ebc211301a254f4ef46325fde75bb6ff82ac558a5c26b12' when '87B72830FD06FFD08EBC211301A254F4EF46325FDE75BB6FF82AC558A5C26B12' was expected
|
Hi @lumag, |
The string isn't, you have listed in in uppercase, but the checksum is compared against the lowercase value as a regular string compare. This is why stray whitespace will also make it fail.
Change all checksums to their expected casing. |
|
Hi, the branch has been rebased. |
|
|
Your PR will require some changes on https://github.com/qualcomm-linux/meta-qcom-distro/blob/main/recipes-products/images/qcom-multimedia-image.bbappend. I'm going to propose a PR moving parts of this file from meta-qcom-distro to meta-qcom, and then you can add it here in the layer. |
qcom-multimedia-image is expected to contain only the open-source software (except for the components to be executed on the non-main cores, e.g on Hexagon DSP). Use INCOMPATIBLE_LICENSE to make sure that no closed-source software can get into qcom-multimedia-image. The setting is performed in the bbappend so that it doesn't affect other images which include qcom-multimedia-image.bb (like the qcom-multimedia-proprietary-image). Fixes qualcomm-linux#1762 Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> (cherry picked from commit cc1db67) qualcomm-linux/meta-qcom-distro@cc1db67 Signed-off-by: Jose Quaresma <jose.quaresma@oss.qualcomm.com>
Listing libvulkan-adreno1 in the BAD_RECOMMENDATIONS makes dnf ignore it and thus pull in meta-vulkan-drivers as a virtual-vulkan-icd provider. Drop unnecessary assignment pulling in meta-vulkan-drivers again. Fixes qualcomm-linux#1762 Fixes: cc1db67c0174 ("qcom-multimedia-image: conflict with proprietary software") Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> (cherry picked from commit 7add89e) qualcomm-linux/meta-qcom-distro@7add89e Signed-off-by: Jose Quaresma <jose.quaresma@oss.qualcomm.com>
|
Please wait for #1864 |
22fff7e to
96a296d
Compare
|
Hi @lumag, |
Fixed with qualcomm-linux/meta-qcom-distro#257 |
| qcom-fastcv-binaries-kaanapali-mtp-dsp \ | ||
| " | ||
|
|
||
| QCOM_CDT_FILE = "cdt_kaanapali_mtp_0.4.0.bin" |
There was a problem hiding this comment.
This should be 'cdt_kaanapali_mtp_0.4.0' only:
classes-recipe/image_types_qcom.bbclass: install -m 0644 ${DEPLOY_DIR_IMAGE}/${QCOM_BOOT_FILES_SUBDIR}/${QCOM_CDT_FILE}.bin cdt.bin
ricardosalveti
left a comment
There was a problem hiding this comment.
QCOM_CDT_FILE needs fixing.
Add a boot firmware recipe for Kaanapali-MTP board. Signed-off-by: Arohi Paigavan <apaigava@qti.qualcomm.com> Signed-off-by: Paigavan, Arohi <apaigava@qti.qualcomm.com>
96a296d to
fc95215
Compare
|
Hi @ricardosalveti , |
The ".bin" was removed on the last commit but it should be in the second. |
Update the KAANAPALI-MTP machine configuration to add the boot firmware, cdt and specify the paths of partition binaries to consume them in flat build. Signed-off-by: Arohi Paigavan <apaigava@qti.qualcomm.com>
The updated boot firmware follows the standard UEFI boot flow, so ABL is no longer used on Kaanapali-MTP. Signed-off-by: Arohi Paigavan <apaigava@qti.qualcomm.com>
fc95215 to
87e1b16
Compare
|
Add boot firmware support for Kaanapali-MTP and updating the machine configuration.
Switch the board to use systemd-boot and remove the ABL_SIGNATURE_VERSION definition, as abl2esp.elf is no longer required.