Add SElinux policy for NHX test app#1667
Merged
ricardosalveti merged 1 commit intoqualcomm-linux:masterfrom Mar 26, 2026
Merged
Add SElinux policy for NHX test app#1667ricardosalveti merged 1 commit intoqualcomm-linux:masterfrom
ricardosalveti merged 1 commit intoqualcomm-linux:masterfrom
Conversation
rohibira-qipl
requested review from
anujm1,
koenkooi,
lumag,
ndechesne,
ricardosalveti,
sbanerjee-quic and
vkraleti
as code owners
rohibira-qipl
force-pushed
the
camera_upstream
branch
from
011d6a5 to
4b1ccc1
Compare
Contributor
|
No commit message, not using your actual name in the commit and sign-off-by, no description or justification for the change, etc. |
Contributor
|
Also please follow the commit message pattern we use in this repository, check with git log. |
rohibira-qipl
force-pushed
the
camera_upstream
branch
2 times, most recently
from
b6d5732 to
27bbc65
Compare
lumag
requested changes
Mar 9, 2026
| Date: Wed, 25 Feb 2026 22:01:44 +0530 | ||
| Subject: [PATCH] Add SELinux policy for nhx.sh | ||
|
|
||
| This adds a new policy module for the nativehaltest camera test application. |
Contributor
There was a problem hiding this comment.
This is obvious. Anything more specific to say?
Contributor
Author
There was a problem hiding this comment.
Added detailed commit message.
Contributor
There was a problem hiding this comment.
And the patch wasn't updated.
rohibira-qipl
force-pushed
the
camera_upstream
branch
from
27bbc65 to
ce8f686
Compare
lumag
reviewed
Mar 11, 2026
Contributor
lumag
left a comment
lumag
left a comment
There was a problem hiding this comment.
These tools are part of the vendor-specific nativehaltest suite located
in 'vendor/qcom/proprietary/'
-ENOSUCHDIR
This patch adds SELinux policy rules to support Qualcomm's proprietary
Don't describe patch contents. Start commit messages from the description of the issue you are solving. What does not work and why?
rohibira-qipl
force-pushed
the
camera_upstream
branch
from
ce8f686 to
f382c2f
Compare
ricardosalveti
approved these changes
Mar 16, 2026
anujm1
approved these changes
Mar 16, 2026
Test run workflowTest jobs for commit f382c2f
All jobs summary
|
Test Results 28 files ±0 28 suites ±0 1h 5m 10s ⏱️ + 5m 3s For more details on these failures, see this check. Results for commit b0d61d3. ± Comparison against base commit fd0469e. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
lumag
approved these changes
Mar 18, 2026
Contributor
|
Please rebase to fix the conflict with master. |
The proprietary camera testing script 'nhx.sh' currently executes in the generic 'initrc_t' domain. This configuration lacks proper process isolation and fails to define the specific permissions required by the 'nativehaltest' application it launches. Define a new policy module 'qcom_nhx' to transition these tools into their own confined domains: - qcom_nhx_launcher_t: For 'nhx.sh', allowing it to read /sys/devices/soc0/soc_id for SoC detection. - qcom_nhx_t: For 'nativehaltest', granting access to the CamX framework, DMA, FastRPC, V4L video nodes, and camera cache directories. These tools are installed to /usr/bin/ and depends on the closed-source CamX framework. As such, this policy is inappropriate for upstream submission. Signed-off-by: Rohit Biradar <rohibira@qti.qualcomm.com>
rohibira-qipl
force-pushed
the
camera_upstream
branch
from
f382c2f to
b0d61d3
Compare
Test run workflowTest jobs for commit b0d61d3
All jobs summary
|
ricardosalveti
merged commit 3d14d26
into
qualcomm-linux:master
364 of 367 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a patch implementing SELinux policy for nhx.sh and nativehaltest camera test app.