Skip to content

Add qref and refgen regulator for tcsr and phy#1476

Open
qianyu-qcom wants to merge 5 commits into
qualcomm-linux:tech/all/dt/glymurfrom
qianyu-qcom:tech/all/dt/glymur
Open

Add qref and refgen regulator for tcsr and phy#1476
qianyu-qcom wants to merge 5 commits into
qualcomm-linux:tech/all/dt/glymurfrom
qianyu-qcom:tech/all/dt/glymur

Conversation

@qianyu-qcom

Copy link
Copy Markdown

No description provided.

…PHY on Glymur

The PCIe PHYs on Glymur require a reference voltage provided by REFGEN,
which in turn is powered by two LDOs.

Since there is no devicetree node for REFGEN, add the vdda-refgen0p9 and
vdda-refgen1p2 supplies for each PCIe PHY node.

Link: https://lore.kernel.org/all/20260623-phy_refgen-v2-0-4d15983bf91d@oss.qualcomm.com/
Signed-off-by: Qiang Yu <qiang.yu@oss.qualcomm.com>
The TCSR clkref_en clocks gate the QREF block which provides reference
clocks to the PCIe PHYs. Wire up the LDO supplies required by the QREF
and refgen blocks on the CRD board.

Link: https://lore.kernel.org/all/20260702-tcsr_qref_0702-v7-0-776f2811b7af@oss.qualcomm.com/
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Qiang Yu <qiang.yu@oss.qualcomm.com>
Mahua has a different QREF topology from Glymur. Override the TCSR
compatible to qcom,mahua-tcsr in mahua.dtsi, and wire up the required
LDO supplies on the CRD board.

Unlike the other PCIe controllers, PCIe5 PHY on Mahua gets its refclk
from the CXO0 pad directly and requires no QREF clkref_en voting. Hence,
point its ref clock at RPMH_CXO_CLK.

Link: https://lore.kernel.org/all/20260702-tcsr_qref_0702-v7-0-776f2811b7af@oss.qualcomm.com/
Signed-off-by: Qiang Yu <qiang.yu@oss.qualcomm.com>
@qcomlnxci qcomlnxci requested review from a team, Amit Kucheria (idlethread), knaveen-qc and Shiraz Hashim (shashim-quic) and removed request for a team July 3, 2026 20:11
@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1476

PR: #1476
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28681415538

# Error File:Line PR-introduced? Root Cause
1 Merge conflict (content) arch/arm64/boot/dts/qcom/glymur-crd.dts Yes PR adds &tcsr node at end of file; conflicts with changes in base branch
2 Merge conflict (content) arch/arm64/boot/dts/qcom/glymur-crd.dtsi Yes PR adds refgen supplies to PCIe PHY nodes; conflicts with changes in base branch

Verdict

Both failures are merge conflicts introduced by this PR conflicting with the base branch tech/all/dt/glymur; no compilation errors detected.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1476

PR: #1476
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28681415538

# Error File:Line PR-introduced? Root Cause
1 Merge conflict (content) arch/arm64/boot/dts/qcom/glymur-crd.dts No Pre-existing: Baseline branch qcom-next has conflicting changes to the same file modified by this PR. The PR adds TCSR QREF supplies, but the baseline has made other changes that conflict.
2 Merge conflict (content) arch/arm64/boot/dts/qcom/glymur-crd.dtsi No Pre-existing: Baseline branch qcom-next has conflicting changes to the same file modified by this PR. The PR adds PCIe PHY refgen supplies, but the baseline has made other changes that conflict.

Verdict

This is not a compilation failure. The build failed during the automerge/integration phase due to merge conflicts between the PR branch and the baseline qcom-next branch. Both conflicts are in files modified by this PR, but the conflicts are caused by pre-existing changes in the baseline branch, not by errors in the PR code itself. The PR's device tree changes are syntactically correct but cannot be cleanly merged with the current baseline state.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

PR #1476 — validate-patch

PR: #1476

Verdict Issues Detailed Report
⚠️ 2 Full report

Final Summary

  1. Lore link present: Yes — all three commits have lore.kernel.org links in Link: tags
  2. Lore link matches PR commits: Cannot verify — network access restricted; however, Link tags point to cover letters (patch 0) instead of individual patches, which should be corrected
  3. Upstream patch status: ⏭️ Skipped — cannot fetch lore threads due to network restrictions
  4. PR present in qcom-next: No — searched qcom-next for all three commit subjects; none found
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1476
Commits: 3 commits (all FROMLIST)
Verdict: ⚠️ PARTIAL


Commit 1/3: FROMLIST: arm64: dts: qcom: glymur-crd: Add refgen supplies for PCIe PHY on Glymur

Upstream: https://lore.kernel.org/all/20260623-phy_refgen-v2-0-4d15983bf91d@oss.qualcomm.com/

Commit Message

Check Status Note
Subject matches upstream ⏭️ Cannot verify — network access restricted
Body preserves rationale ⏭️ Cannot verify — network access restricted
Fixes tag present/correct No Fixes tag (not a bugfix)
Authorship preserved FROMLIST: From: Qiang Yu; Signed-off-by: Qiang Yu present
Backport note (if applicable) N/A FROMLIST, not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/glymur-crd.dtsi ⏭️ Cannot compare to lore — network restricted

Commit 2/3: FROMLIST: arm64: dts: qcom: glymur: Add QREF regulator supplies to TCSR

Upstream: https://lore.kernel.org/all/20260702-tcsr_qref_0702-v7-0-776f2811b7af@oss.qualcomm.com/

Commit Message

Check Status Note
Subject matches upstream ⏭️ Cannot verify — network access restricted
Body preserves rationale ⏭️ Cannot verify — network access restricted
Fixes tag present/correct No Fixes tag (not a bugfix)
Authorship preserved FROMLIST: From: Qiang Yu; Signed-off-by: Qiang Yu present
Reviewed-by present Reviewed-by: Konrad Dybcio konrad.dybcio@oss.qualcomm.com
Backport note (if applicable) N/A FROMLIST, not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/glymur-crd.dts ⏭️ Cannot compare to lore — network restricted

Commit 3/3: FROMLIST: arm64: dts: qcom: mahua: Add QREF regulator supplies to TCSR

Upstream: https://lore.kernel.org/all/20260702-tcsr_qref_0702-v7-0-776f2811b7af@oss.qualcomm.com/

Commit Message

Check Status Note
Subject matches upstream ⏭️ Cannot verify — network access restricted
Body preserves rationale ⏭️ Cannot verify — network access restricted
Fixes tag present/correct No Fixes tag (not a bugfix)
Authorship preserved FROMLIST: From: Qiang Yu; Signed-off-by: Qiang Yu present
Backport note (if applicable) N/A FROMLIST, not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/mahua-crd.dts ⏭️ Cannot compare to lore — network restricted
arch/arm64/boot/dts/qcom/mahua.dtsi ⏭️ Cannot compare to lore — network restricted

Issues

⚠️ Link format concern:

  • Commit 1 links to cover letter: 20260623-phy_refgen-v2-0-4d15983bf91d@oss.qualcomm.com (note the -0- indicating patch 0/N)
  • Commits 2 & 3 link to cover letter: 20260702-tcsr_qref_0702-v7-0-776f2811b7af@oss.qualcomm.com (note the -0- indicating patch 0/N)

Recommendation: For individual commits in a series, the Link: tag should point to the specific patch message-ID, not the cover letter. Cover letter links are appropriate only when the entire series is squashed into one commit. For multi-commit PRs like this one, each commit should link to its corresponding patch in the series (e.g., -1-, -2-, -3- for patches 1, 2, 3).

Example correction:

Commit 1: Link: https://lore.kernel.org/all/20260623-phy_refgen-v2-1-4d15983bf91d@oss.qualcomm.com/
Commit 2: Link: https://lore.kernel.org/all/20260702-tcsr_qref_0702-v7-1-776f2811b7af@oss.qualcomm.com/
Commit 3: Link: https://lore.kernel.org/all/20260702-tcsr_qref_0702-v7-2-776f2811b7af@oss.qualcomm.com/

Verdict

⚠️ PARTIAL — Recommend updating Link tags before merge

The commits follow correct FROMLIST authorship rules (submitter Qiang Yu has proper Signed-off-by), commit messages are well-structured with clear rationale, and the prefix usage is appropriate. However, the Link tags point to cover letters instead of individual patch message-IDs, which makes it harder to trace each commit back to its specific upstream discussion.

Recommended action: Update the Link: tags in each commit to point to the specific patch message-ID (change -0- to -1-, -2-, -3- respectively) before merging. This is a metadata-only fix that improves traceability without changing code.


Final Summary

  1. Lore link present: Yes — all three commits have lore.kernel.org links in Link: tags
  2. Lore link matches PR commits: Cannot verify — network access restricted; however, Link tags point to cover letters (patch 0) instead of individual patches, which should be corrected
  3. Upstream patch status: ⏭️ Skipped — cannot fetch lore threads due to network restrictions
  4. PR present in qcom-next: No — searched qcom-next for all three commit subjects; none found

@qlijarvis

Copy link
Copy Markdown

PR #1476 — checker-log-analyzer

PR: #1476
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28681415539

Checker Result Summary
Checker Result Summary
checkpatch ⏭️ CI merge failure - no jobs ran
dt-binding-check ⏭️ CI merge failure - no jobs ran
dtb-check ⏭️ CI merge failure - no jobs ran
sparse-check ⏭️ CI merge failure - no jobs ran
check-uapi-headers ⏭️ CI merge failure - no jobs ran
check-patch-compliance ⏭️ CI merge failure - no jobs ran
tag-check All 3 commits have valid FROMLIST: prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1476 - Add QREF regulator supplies for PCIe PHY on Glymur and Mahua
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/28681415539

Checker Result Summary
checkpatch ⏭️ CI merge failure - no jobs ran
dt-binding-check ⏭️ CI merge failure - no jobs ran
dtb-check ⏭️ CI merge failure - no jobs ran
sparse-check ⏭️ CI merge failure - no jobs ran
check-uapi-headers ⏭️ CI merge failure - no jobs ran
check-patch-compliance ⏭️ CI merge failure - no jobs ran
tag-check All 3 commits have valid FROMLIST: prefix

⚠️ CI Infrastructure Failure

Root cause: Git merge failure during CI setup - "fatal: refusing to merge unrelated histories"

Failure details:
All six checker jobs failed at the merge preparation stage with the same error:

fatal: refusing to merge unrelated histories
Merge failed or conflicts detected. Aborting merge.
##[error]Process completed with exit code 3.

The CI workflow attempted to:

  1. Checkout qcom-next baseline (Linux 7.1)
  2. Run automerge to integrate topic branch tech/all/dt/glymur
  3. Merge PR Add qref and refgen regulator for tcsr and phy #1476 on top

The failure occurred at step 3 when trying to merge the PR branch into the automerged tree. The error "refusing to merge unrelated histories" indicates that the PR branch (tech/all/dt/glymur from qualcomm-linux/kernel-topics) has no common Git ancestry with the qcom-next baseline.

This is a CI workflow/infrastructure issue, not a patch quality defect.

Fix:

The PR branch needs to be rebased onto a commit that shares history with qcom-next, or the CI workflow needs to be adjusted to handle topic branches with independent histories. Possible actions:

  1. Rebase the topic branch tech/all/dt/glymur onto qcom-next or a common ancestor
  2. Use --allow-unrelated-histories in the CI merge step (if appropriate for the workflow)
  3. Verify the topic branch base - ensure tech/all/dt/glymur was created from the correct baseline

Reproduce locally:

git clone https://github.com/qualcomm-linux/kernel.git
cd kernel
git checkout qcom-next
git fetch https://github.com/qualcomm-linux/kernel-topics.git tech/all/dt/glymur:topic
git merge topic  # Will fail with "refusing to merge unrelated histories"

✅ Manual tag-check (Step 2.7)

Since the target branch is tech/all/dt/glymur (not qcom-next or qcom-next-staging), every commit must have a valid subject prefix.

Analysis:
All 3 commits in the PR have the required FROMLIST: prefix:

  1. FROMLIST: arm64: dts: qcom: glymur-crd: Add refgen supplies for PCIe PHY on Glymur
  2. FROMLIST: arm64: dts: qcom: glymur: Add QREF regulator supplies to TCSR
  3. FROMLIST: arm64: dts: qcom: mahua: Add QREF regulator supplies to TCSR

All commits include proper Link: tags pointing to lore.kernel.org and Signed-off-by: trailers.

Verdict: ✅ PASS


Verdict

The PR patches themselves appear well-formed (proper prefixes, Link tags, sign-offs), but cannot be evaluated by CI due to a merge infrastructure failure.

Action required: Fix the Git history relationship between the topic branch and qcom-next baseline, then re-trigger CI. No patch changes are needed based on the available information.

…R for glymur-qcb

Wire up the required LDO supplies on the QCB board.

Signed-off-by: Qiang Yu <qiang.yu@oss.qualcomm.com>
…R for mahua-qcb

Wire up the required LDO supplies on the QCB board.

Signed-off-by: Qiang Yu <qiang.yu@oss.qualcomm.com>
@qcomlnxci qcomlnxci requested a review from a team July 4, 2026 02:00
@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1476

PR: #1476
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28691517785

# Error File:Line PR-introduced? Root Cause
1 Merge conflict arch/arm64/boot/dts/qcom/glymur-crd.dts Yes PR modifies &tcsr node which conflicts with concurrent changes in the integration branch
2 Merge conflict arch/arm64/boot/dts/qcom/glymur-crd.dtsi Yes PR adds vdda-refgen* supplies to PCIe PHY nodes that conflict with other changes
3 Merge conflict arch/arm64/boot/dts/qcom/glymur.dtsi No Pre-existing conflict in base devicetree file not touched by this PR

Verdict

This is NOT a compilation failure. The build failed during the merge/integration phase before any compilation occurred. 2 of 3 merge conflicts are directly caused by this PR's changes to devicetree files; 1 conflict is in a file not modified by the PR.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1476

PR: #1476
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28691517785

# Error File:Line PR-introduced? Root Cause
N/A Merge conflict failure (not a compilation error) Multiple files No Base branch divergence

Verdict

This is not a compilation failure. The build failed during the pre-merge integration step due to 90+ merge conflicts between the PR branch and the baseline (qcom-next). Only 2 of the 90+ conflicting files are actually modified by this PR. The conflicts are caused by base branch divergence, not by the PR changes themselves.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

PR #1476 — validate-patch

PR: #1476

Verdict Issues Detailed Report
PARTIAL 11 Full report

Final Summary

  1. Lore link present:

    • Commits 1-3 (FROMLIST): Yes - proper lore.kernel.org links present
    • Commits 4-5 (PENDING): No - PENDING prefix; no lore link expected or required
  2. Lore link matches PR commits:

    • Commits 1-3: ⏭️ Cannot verify - network restricted (lore.kernel.org unreachable)
    • Commits 4-5: N/A - no lore link to compare against
  3. Upstream patch status:

    • Commits 1-3: ⏭️ Cannot verify - network restricted (cannot fetch lore threads or check git trees)
    • Commits 4-5: N/A - vendor-only PENDING commits, not posted upstream
  4. PR present in qcom-next:

    • All commits: ⏭️ Cannot verify - repo access restricted (permission denied on pre-mounted repo, cannot clone)
Verdict: PARTIAL — click to expand

🔍 Patch Validation

PR: #1476
Commits: 5 commits (3 FROMLIST, 2 PENDING)
Verdict: ⏭️ PARTIAL VALIDATION (network restrictions prevented full upstream verification)


Commit 1/5: FROMLIST: arm64: dts: qcom: glymur-crd: Add refgen supplies for PCIe PHY on Glymur

Upstream: https://lore.kernel.org/all/20260623-phy_refgen-v2-0-4d15983bf91d@oss.qualcomm.com/

Commit Message

Check Status Note
Subject matches upstream ⏭️ Cannot verify - network restricted
Body preserves rationale Clear description of PCIe PHY refgen requirements
Fixes tag present/correct N/A Not a fix commit
Authorship preserved ⏭️ FROMLIST: submitter in From: is correct; cannot verify lore author's Signed-off-by: without network access
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/glymur-crd.dtsi Adds vdda-refgen0p9/1p2 supplies to 4 PCIe PHY nodes (pcie3b_phy, pcie4_phy, pcie5_phy, pcie6_phy)

Commit 2/5: FROMLIST: arm64: dts: qcom: glymur: Add QREF regulator supplies to TCSR

Upstream: https://lore.kernel.org/all/20260702-tcsr_qref_0702-v7-0-776f2811b7af@oss.qualcomm.com/

Commit Message

Check Status Note
Subject matches upstream ⏭️ Cannot verify - network restricted
Body preserves rationale Clear description of TCSR QREF block and LDO supplies
Fixes tag present/correct N/A Not a fix commit
Authorship preserved ⏭️ FROMLIST: submitter in From: is correct; cannot verify lore author's Signed-off-by: without network access
Backport note (if applicable) N/A Not a backport
Reviewed-by present Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Diff

File Status Notes
arch/arm64/boot/dts/qcom/glymur-crd.dts Adds 8 vdda-qref* supplies to &tcsr node

Commit 3/5: FROMLIST: arm64: dts: qcom: mahua: Add QREF regulator supplies to TCSR

Upstream: https://lore.kernel.org/all/20260702-tcsr_qref_0702-v7-0-776f2811b7af@oss.qualcomm.com/

Commit Message

Check Status Note
Subject matches upstream ⏭️ Cannot verify - network restricted
Body preserves rationale Explains Mahua-specific QREF topology and PCIe5 PHY CXO0 refclk
Fixes tag present/correct N/A Not a fix commit
Authorship preserved ⏭️ FROMLIST: submitter in From: is correct; cannot verify lore author's Signed-off-by: without network access
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/mahua-crd.dts Adds 13 vdda-qref*/vdda-refgen* supplies to &tcsr
arch/arm64/boot/dts/qcom/mahua.dtsi Overrides pcie5_phy clocks (adds RPMH_CXO_CLK) and tcsr compatible to qcom,mahua-tcsr

Commit 4/5: PENDING: arm64: dts: qcom: glymur: Add QREF regulator supplies to TCSR for glymur-qcb

Upstream: N/A (PENDING prefix - vendor-only, not posted upstream)

Commit Message

Check Status Note
Subject format Correct PENDING prefix
Body preserves rationale Brief but clear: "Wire up the required LDO supplies on the QCB board"
Fixes tag present/correct N/A Not a fix commit
Authorship Vendor commit - author is submitter
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/glymur-qcb.dts Adds 14 vdda-qref*/vdda-refgen* supplies to &tcsr for QCB board variant

Commit 5/5: PENDING: arm64: dts: qcom: glymur: Add QREF regulator supplies to TCSR for mahua-qcb

Upstream: N/A (PENDING prefix - vendor-only, not posted upstream)

Commit Message

Check Status Note
Subject format Correct PENDING prefix
Body preserves rationale Brief but clear: "Wire up the required LDO supplies on the QCB board"
Fixes tag present/correct N/A Not a fix commit
Authorship Vendor commit - author is submitter
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/mahua-qcb.dts Adds 13 vdda-qref*/vdda-refgen* supplies to &tcsr for Mahua QCB board variant

Issues

Network Restrictions:

  • Cannot fetch lore.kernel.org patches to verify diff faithfulness (commits 1-3)
  • Cannot verify upstream patch acceptance status (commits 1-3)
  • Cannot check qcom-next presence (all commits) - repo access restricted

Commit Message Observations:

  • All FROMLIST commits (1-3) have proper Link: tags pointing to lore.kernel.org
  • Commit 2 has Reviewed-by: tag from Konrad Dybcio - positive upstream signal
  • PENDING commits (4-5) correctly have no lore links (vendor-only)
  • All commits have proper Signed-off-by: from author Qiang Yu

Diff Structure:

  • All changes are devicetree additions (supply properties)
  • No code logic changes - low risk
  • Consistent pattern across all commits: adding vdda-* supply properties to PCIe PHY and TCSR nodes
  • Changes are board-specific (CRD and QCB variants for Glymur and Mahua)

Verdict

⏭️ PARTIAL VALIDATION - Cannot fully verify due to network restrictions

What was validated locally:

  • ✅ Commit message structure and format
  • ✅ Proper use of FROMLIST and PENDING prefixes
  • ✅ Lore links present for FROMLIST commits
  • ✅ Authorship and sign-off present
  • ✅ Diff structure is clean and focused (devicetree supply additions only)
  • ✅ Logical progression: upstream patches (1-3) followed by vendor QCB variants (4-5)

What could not be verified (network restricted):

  • ⏭️ Diff faithfulness to lore upstream patches
  • ⏭️ Upstream patch acceptance status
  • ⏭️ Presence in qcom-next branch
  • ⏭️ Original lore author's Signed-off-by in FROMLIST commits

Recommendation:
The PR structure and commit messages follow proper conventions. The changes are low-risk devicetree additions. However, manual verification is required for:

  1. Fetch lore patches for commits 1-3 and verify diff content matches
  2. Check upstream acceptance status of the two lore series (phy_refgen-v2 and tcsr_qref_0702-v7)
  3. Verify original lore authors' Signed-off-by lines are present in commits 1-3

Final Summary

  1. Lore link present:

    • Commits 1-3 (FROMLIST): Yes - proper lore.kernel.org links present
    • Commits 4-5 (PENDING): No - PENDING prefix; no lore link expected or required
  2. Lore link matches PR commits:

    • Commits 1-3: ⏭️ Cannot verify - network restricted (lore.kernel.org unreachable)
    • Commits 4-5: N/A - no lore link to compare against
  3. Upstream patch status:

    • Commits 1-3: ⏭️ Cannot verify - network restricted (cannot fetch lore threads or check git trees)
    • Commits 4-5: N/A - vendor-only PENDING commits, not posted upstream
  4. PR present in qcom-next:

    • All commits: ⏭️ Cannot verify - repo access restricted (permission denied on pre-mounted repo, cannot clone)

@qlijarvis

Copy link
Copy Markdown

PR #1476 — checker-log-analyzer

PR: #1476
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28691516863

Checker Result Summary
Checker Result Summary
checkpatch ⚠️ CI infrastructure failure - merge failed
dt-binding-check ⚠️ CI infrastructure failure - merge failed
dtb-check ⚠️ CI infrastructure failure - merge failed
sparse-check ⚠️ CI infrastructure failure - merge failed
check-uapi-headers ⚠️ CI infrastructure failure - merge failed
check-patch-compliance ⚠️ CI infrastructure failure - merge failed
tag-check ⚠️ Cannot verify - commits 4 & 5 use PENDING: prefix
qcom-next-check N/A Target branch unknown

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1476 - Add QREF regulator supplies for PCIe PHY and TCSR on Glymur/Mahua
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/28691516863

Checker Result Summary
checkpatch ⚠️ CI infrastructure failure - merge failed
dt-binding-check ⚠️ CI infrastructure failure - merge failed
dtb-check ⚠️ CI infrastructure failure - merge failed
sparse-check ⚠️ CI infrastructure failure - merge failed
check-uapi-headers ⚠️ CI infrastructure failure - merge failed
check-patch-compliance ⚠️ CI infrastructure failure - merge failed
tag-check ⚠️ Cannot verify - commits 4 & 5 use PENDING: prefix
qcom-next-check N/A Target branch unknown

⚠️ CI Infrastructure Failure

Root cause: All checker jobs failed during the merge setup phase before any actual checks could run.

Failure details:

2026-07-04T02:17:22.4585683Z  ** Merging topic branch: topic/tech/all/dt/glymur
2026-07-04T02:17:41.2114499Z fatal: refusing to merge unrelated histories
2026-07-04T02:17:41.3197147Z Merge failed, manual merge
...
2026-07-04T02:17:42.2767989Z Merging pr-1476 (no-commit)...
2026-07-04T02:18:03.1635470Z fatal: refusing to merge unrelated histories
2026-07-04T02:18:03.2927700Z Merge failed or conflicts detected. Aborting merge.
2026-07-04T02:18:03.2963134Z ##[error]Process completed with exit code 3.

This error occurred identically in all 6 checker jobs:

  • checkpatch
  • dt-binding-check
  • dtb-check
  • sparse-check
  • check-uapi-headers
  • check-patch-compliance

Analysis:

The CI workflow attempts to:

  1. Create an integration branch based on baseline commit 19b282f417584cfe14ce6a262122c51553d026ec
  2. Merge topic branch topic/tech/all/dt/glymur into the integration branch
  3. Merge PR Add qref and refgen regulator for tcsr and phy #1476 into the integration branch

Both merge operations fail with "refusing to merge unrelated histories", indicating that:

This is a repository configuration or CI workflow issue, not a patch quality defect.

Possible causes:

  1. The PR branch was created from a different baseline than expected
  2. The topic branch topic/tech/all/dt/glymur was created with --orphan or rebased onto an incompatible base
  3. The CI is attempting to merge branches from different repositories with no shared history
  4. The baseline commit 19b282f417584cfe14ce6a262122c51553d026ec is not an ancestor of the PR branch

Fix:

This requires investigation and action by the repository maintainers:

  1. Verify the PR base branch:

    gh pr view 1476 --repo qualcomm-linux/kernel-topics --json baseRefName,headRefName
  2. Check if the PR branch has the baseline commit in its history:

    git log --oneline --graph pr-1476 | grep 19b282f4
  3. If the PR was created from the wrong base, rebase it:

    git checkout pr-1476
    git rebase --onto <correct-base> <old-base>
    git push --force-with-lease
  4. If the topic branch is the issue, investigate its history:

    git log --oneline topic/tech/all/dt/glymur
    git merge-base topic/tech/all/dt/glymur 19b282f417584cfe14ce6a262122c51553d026ec
  5. Re-trigger the CI run after fixing the branch ancestry issue.

Reproduce locally:

# Clone the repo and fetch the PR
git clone https://github.com/qualcomm-linux/kernel-topics.git
cd kernel-topics
git fetch origin pull/1476/head:pr-1476

# Try to reproduce the merge failure
git checkout 19b282f417584cfe14ce6a262122c51553d026ec
git checkout -b test-integ
git merge topic/tech/all/dt/glymur  # Should fail with "unrelated histories"
git merge pr-1476                    # Should fail with "unrelated histories"

⚠️ tag-check (Predicted Issue)

Note: This check could not run due to the CI infrastructure failure, but based on the patch content, there is a predicted issue with commits 4 and 5.

Predicted failure details:

Commits 4 and 5 use the PENDING: prefix:

  • Commit 4: PENDING: arm64: dts: qcom: glymur: Add QREF regulator supplies to TCSR for glymur-qcb
  • Commit 5: PENDING: arm64: dts: qcom: glymur: Add QREF regulator supplies to TCSR for mahua-qcb

Impact depends on target branch:

  • If target branch is qcom-next or qcom-next-staging: ✅ PASS - subject prefix not required
  • If target branch is any other branch: ❌ FAIL - PENDING: is not an accepted prefix for check-patch-compliance

The check-patch-compliance checker only accepts these prefixes:

  • FROMLIST: (posted to mailing list)
  • FROMGIT: (from maintainer tree)
  • UPSTREAM: (merged into mainline)
  • BACKPORT: (backported with modifications)

PENDING: is a vendor-internal prefix that will always fail the compliance check on non-qcom-next branches.

Fix (if target branch is not qcom-next/qcom-next-staging):

If these commits have been posted to a mailing list, change the prefix to FROMLIST: and add a Link: tag:

git rebase -i <base_sha>   # mark commits 4 & 5 as 'edit'
# For each commit:
git commit --amend -m "FROMLIST: arm64: dts: qcom: glymur: Add QREF regulator supplies to TCSR for glymur-qcb

Wire up the required LDO supplies on the QCB board.

Link: https://lore.kernel.org/all/<message-id>
Signed-off-by: Qiang Yu <qiang.yu@oss.qualcomm.com>"
git rebase --continue

If these commits are truly pending (not yet posted), they should either:

  1. Be posted upstream first, then use FROMLIST: prefix
  2. Remain in a separate branch until posted
  3. Be merged only to qcom-next or qcom-next-staging where prefix requirements are relaxed

Verdict

Cannot assess patch quality - all checker jobs failed during CI setup before any validation could run.

Immediate action required:

  1. Fix the branch ancestry issue - investigate why the PR branch and topic branch have no common ancestor with the baseline
  2. Re-trigger CI after fixing the merge issue
  3. Address the PENDING: prefix issue in commits 4 & 5 if the target branch is not qcom-next or qcom-next-staging

Patch content review (manual inspection):

The patches themselves appear well-formed:

  • ✅ All commits have proper Signed-off-by: tags
  • ✅ Commits 1-3 have FROMLIST: prefix and Link: tags pointing to lore.kernel.org
  • ✅ Commit 2 has Reviewed-by: tag
  • ✅ Changes are DTS-only (devicetree supply additions)
  • ⚠️ Commits 4-5 use PENDING: prefix without Link: tags (expected for pending work, but will fail compliance check on most branches)

Once the CI infrastructure issue is resolved, the checkers should be able to run and provide proper validation results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants