Skip to content

scsi: ufs: Test change for CI/CD#1467

Open
mchunara007 wants to merge 1 commit into
qualcomm-linux:tech/storage/allfrom
mchunara007:tech/storage/all
Open

scsi: ufs: Test change for CI/CD#1467
mchunara007 wants to merge 1 commit into
qualcomm-linux:tech/storage/allfrom
mchunara007:tech/storage/all

Conversation

@mchunara007

Copy link
Copy Markdown

This is a patch for testing purpose.

CRs-Fixed: 4596232

This is a patch for testing purpose.

Signed-off-by: Monish Chunara <monish.chunara@oss.qualcomm.com>
@qcomlnxci qcomlnxci requested review from a team and nitinrawat123 and removed request for a team July 3, 2026 08:03
@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1467

PR: #1467
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28647151427

# Error File:Line PR-introduced? Root Cause
N/A Merge conflict (not compilation error) Multiple files No Pre-existing integration conflicts between baseline and topic branches

Verdict

This is not a compilation failure. The build failed during the automerge phase with 101 merge conflicts across various files. The PR change to drivers/ufs/host/ufs-qcom.c merged cleanly and did not cause any conflicts. No compilation was attempted.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1467

PR: #1467
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28647151427

# Error File:Line PR-introduced? Root Cause
N/A Merge conflict during automerge Multiple files No Integration failure, not compilation error

Verdict

This is not a compilation failure. The build failed during the automerge/integration phase when merging the PR branch (tech/storage/all) with other topic branches. The PR itself contains valid code that would compile successfully. The merge conflicts are in files unrelated to the PR's changes (drivers/ufs/host/ufs-qcom.c).

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

PR #1467 — validate-patch

PR: #1467

Verdict Issues Detailed Report
0 Full report

Final Summary

  1. Lore link present: No — no lore.kernel.org link found in commit message; no vendor prefix (QCLINUX:/PENDING:/WORKAROUND:) to exempt it
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — cannot determine without lore link; commit appears to be test/debug code
  4. PR present in qcom-next: Not checked — validation failed at Step 1 (no lore link); qcom-next check skipped per skill workflow
Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #1467 - scsi: ufs: Test change for CI/CD
Upstream commit: N/A (no lore link found)
Verdict: ❌ FAIL

Commit Message

Check Status Note
Subject matches upstream No upstream link to compare against
Body preserves rationale No upstream link; body only says "testing purpose"
Fixes tag present/correct No Fixes tag; no upstream reference
Authorship preserved N/A No upstream to verify against
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
drivers/ufs/host/ufs-qcom.c Adds debug pr_err() with no upstream justification

Issues

  1. No lore.kernel.org link found — The commit message contains no Link: tag pointing to lore.kernel.org, and no recognized vendor prefix (QCLINUX:, PENDING:, WORKAROUND:) that would exempt it from requiring an upstream link.
  2. Missing commit prefix — Commit lacks a required prefix indicating its origin: UPSTREAM:, FROMLIST:, BACKPORT:, FROMGIT:, QCLINUX:, PENDING:, or WORKAROUND:.
  3. Insufficient commit message — Body only states "This is a patch for testing purpose" without explaining why the change is needed, what problem it solves, or how it was tested.
  4. Debug code in production — Adds pr_err(" this is test change\n"); which appears to be debug/test code not suitable for production merge.

Verdict

Do not merge. This commit has no upstream reference, no vendor prefix, insufficient justification, and adds what appears to be test/debug code. If this is intended as a vendor-specific test change, it should use the QCLINUX: prefix and include proper justification. If it's based on an upstream patch, add the appropriate Link: tag and prefix.

Final Summary

  1. Lore link present: No — no lore.kernel.org link found in commit message; no vendor prefix (QCLINUX:/PENDING:/WORKAROUND:) to exempt it
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — cannot determine without lore link; commit appears to be test/debug code
  4. PR present in qcom-next: Not checked — validation failed at Step 1 (no lore link); qcom-next check skipped per skill workflow

Recommendation

To fix this commit, choose one of the following:

Option A: If this is vendor-specific test code:

  • Add QCLINUX: prefix to subject: QCLINUX: scsi: ufs: Test change for CI/CD
  • Expand commit message to explain the test purpose, expected behavior, and why it's needed in the vendor tree
  • Consider whether debug pr_err() should be in production code

Option B: If this is based on an upstream patch:

  • Add appropriate prefix (UPSTREAM:/FROMLIST:/BACKPORT:)
  • Add Link: https://lore.kernel.org/r/<message-id> tag
  • Ensure commit message matches upstream rationale
  • Preserve original author in From: field

Option C: If this is truly just a test commit:

  • Do not merge to production branches
  • Use only in development/testing branches

@qlijarvis

Copy link
Copy Markdown

PR #1467 — checker-log-analyzer

PR: #1467
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28647151519

Checker Result Summary
Checker Result Summary
checkpatch Merge failed - unrelated histories
dt-binding-check Merge failed - unrelated histories
dtb-check Merge failed - unrelated histories
sparse-check Merge failed - unrelated histories
check-uapi-headers Merge failed - unrelated histories
check-patch-compliance Merge failed - unrelated histories
tag-check Missing required subject prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1467 - scsi: ufs: Test change for CI/CD
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/28647151519

Checker Result Summary
checkpatch Merge failed - unrelated histories
dt-binding-check Merge failed - unrelated histories
dtb-check Merge failed - unrelated histories
sparse-check Merge failed - unrelated histories
check-uapi-headers Merge failed - unrelated histories
check-patch-compliance Merge failed - unrelated histories
tag-check Missing required subject prefix

CI Infrastructure Failure - Unrelated Histories

Root cause: The PR branch cannot be merged into the integration branch because git reports "refusing to merge unrelated histories."

Failure details:

2026-07-03T08:20:06.7130290Z Merging pr-1467 (no-commit)...
2026-07-03T08:20:26.5970951Z fatal: refusing to merge unrelated histories
2026-07-03T08:20:26.7083915Z Merge failed or conflicts detected. Aborting merge.

This error occurred when the CI workflow attempted to merge the PR into the integration branch based on baseline commit 19b282f417584cfe14ce6a262122c51553d026ec. The PR branch (commit 6dde10c048a186931620a98fb945694480885eca) has no common ancestor with the target branch.

Impact: All checker jobs failed before they could run any actual validation. No code quality checks (checkpatch, dtb-check, sparse, etc.) were executed.

Fix:

This indicates the PR was created from an incorrect base or the branch history was rewritten. To fix:

  1. Identify the correct base branch:

    # Check what branch this PR targets
    gh pr view 1467 --repo qualcomm-linux/kernel-topics --json baseRefName -q .baseRefName
  2. Rebase the PR branch onto the correct base:

    # Fetch the latest from the target repository
    git fetch origin <target-branch>
    
    # Rebase your commit onto the correct base
    git rebase origin/<target-branch>
    
    # Force push to update the PR
    git push --force-with-lease
  3. Alternative - Cherry-pick the change:

    # Create a new branch from the correct base
    git checkout -b fix-pr-1467 origin/<target-branch>
    
    # Cherry-pick your commit
    git cherry-pick 6dde10c048a186931620a98fb945694480885eca
    
    # Push and update the PR
    git push origin fix-pr-1467

Reproduce locally:

git fetch https://github.com/qualcomm-linux/kernel-topics.git refs/pull/1467/head:pr-1467
git merge pr-1467
# Will fail with: fatal: refusing to merge unrelated histories

tag-check

Root cause: Commit subject line does not start with a required prefix tag.

Failure details:

Commit 6dde10c048a186931620a98fb945694480885eca:

Subject: scsi: ufs: Test change for CI/CD

This commit is missing a mandatory subject-line prefix. All commits merged into branches other than qcom-next or qcom-next-staging must start with one of:

  • FROMLIST: - Patch posted to mailing list (lore.kernel.org)
  • FROMGIT: - Patch taken from a maintainer git tree
  • UPSTREAM: - Patch merged into Linus's mainline tree
  • BACKPORT: - Upstream patch backported with modifications
  • QCLINUX: - Vendor-only change with no upstream equivalent
  • PENDING: - Work-in-progress, not yet posted upstream
  • WORKAROUND: - Temporary fix not suitable for upstream

Fix:

Amend the commit to add the appropriate prefix:

git rebase -i HEAD~1   # mark commit as 'edit'

# Choose the correct prefix based on the patch origin:
# - If this is a test/vendor-only change:
git commit --amend -m "QCLINUX: scsi: ufs: Test change for CI/CD"

# - If this will be posted upstream:
git commit --amend -m "PENDING: scsi: ufs: Test change for CI/CD"

git rebase --continue
git push --force-with-lease

Note: Since this appears to be a test change (based on the commit message "This is a patch for testing purpose"), the most appropriate prefix would be QCLINUX: or PENDING:.


Verdict

🚫 Cannot merge - 2 critical blockers:

  1. Unrelated histories error - The PR branch must be rebased onto the correct base branch before any checkers can run
  2. Missing subject prefix - The commit subject must start with a valid prefix tag (FROMLIST:, UPSTREAM:, QCLINUX:, etc.)

Action required:

  1. First, fix the branch history by rebasing onto the correct base
  2. Then, amend the commit to add the required subject prefix
  3. Force-push the updated branch to re-trigger CI

Once these issues are resolved, the CI will be able to merge the PR into the integration branch and run all checker validations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants