Skip to content

Topic/glymur sdcard dt v2#1466

Open
Pradeep P V K (Pradeep-pvk) wants to merge 4 commits into
qualcomm-linux:tech/all/dt/glymurfrom
Pradeep-pvk:topic/glymur-sdcard-dt-v2
Open

Topic/glymur sdcard dt v2#1466
Pradeep P V K (Pradeep-pvk) wants to merge 4 commits into
qualcomm-linux:tech/all/dt/glymurfrom
Pradeep-pvk:topic/glymur-sdcard-dt-v2

Conversation

@Pradeep-pvk

Copy link
Copy Markdown
Contributor

SDCARD dt changes for Glymur CRD platform.

@qcomlnxci qcomlnxci requested review from a team, Amit Kucheria (idlethread), knaveen-qc and Shiraz Hashim (shashim-quic) and removed request for a team July 3, 2026 07:53
@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1466

PR: #1466
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28646678506

# Error File:Line PR-introduced? Root Cause
1 Merge conflict arch/arm64/boot/dts/qcom/glymur-crd.dts Yes PR modifies this file; conflicts with baseline changes
2 Merge conflict arch/arm64/boot/dts/qcom/glymur-crd.dtsi Yes PR modifies this file; conflicts with baseline changes
3 Merge conflict arch/arm64/boot/dts/qcom/glymur.dtsi Yes PR modifies this file; conflicts with baseline changes
4-101 Merge conflicts (98 files) Various files No PR branch out of sync with baseline; files not touched by PR

Verdict

This is not a compilation failure but a merge conflict during integration. 3 conflicts are in files modified by this PR; 98 conflicts are in unrelated files indicating the PR branch needs rebasing against the current baseline (19b282f417584cfe14ce6a262122c51553d026ec).

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1466

PR: #1466
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28646678506

# Error File:Line PR-introduced? Root Cause
1 Merge conflict (add/add) Documentation/devicetree/bindings/cpufreq/qcom,shikra-epss.yaml No Pre-existing conflict in baseline merge; file not touched by PR
2 Merge conflict (content) arch/arm64/boot/dts/qcom/glymur-crd.dtsi Partial PR modifies this file; conflict with concurrent changes in baseline
3 Merge conflict (content) arch/arm64/boot/dts/qcom/glymur.dtsi Partial PR modifies this file; conflict with concurrent changes in baseline
4 Merge conflict (content) arch/arm64/boot/dts/qcom/glymur-crd.dts Partial PR modifies this file; conflict with concurrent changes in baseline
5 Merge conflicts in 100+ other files Various (drivers/, Documentation/, include/, sound/) No Pre-existing conflicts in PR base branch; unrelated to PR changes

Verdict

This is NOT a compilation failure. The build failed during the automerge phase when integrating the PR branch tech/all/dt/glymur with the baseline qcom-next. The PR itself introduces no compilation errors. Three of the four files modified by the PR have merge conflicts with the baseline, indicating concurrent development. The remaining 100+ conflicting files are unrelated to this PR and represent pre-existing integration issues in the base branch.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

PR #1466 — validate-patch

PR: #1466

Verdict Issues Detailed Report
PARTIAL 0 Full report

Final Summary

  1. Lore link present: Yes — all 4 commits have lore.kernel.org links in Link: tags
  2. Lore link matches PR commits: Cannot verify — network restricted, unable to fetch upstream patches for comparison
  3. Upstream patch status: Cannot verify — network restricted, unable to check mailing list threads or git trees for acceptance status
  4. PR present in qcom-next: No — none of the 4 commits found in origin/qcom-next (searched by subject)
Verdict: PARTIAL — click to expand

🔍 Patch Validation

PR: #1466 - SD Card support for Glymur
Upstream commits: 4 lore.kernel.org links present
Verdict: ⏭️ PARTIAL (network restricted - cannot fetch upstream patches for comparison)

Network Limitation

⚠️ Cannot fetch lore.kernel.org patches - Network access is restricted in this environment. The following validation steps could not be completed:

  • Fetching upstream patches from lore.kernel.org for diff comparison
  • Checking upstream patch acceptance status (ACKed/NACKed/Pending)
  • Verifying diff content matches lore patches exactly

The validation below covers only what can be verified from the PR patch file itself.


Commit 1: arm64: dts: qcom: glymur-crd: Update VREG l2b_e0 and l9b_e0 voltage for SD-card

Lore link: https://lore.kernel.org/all/20260702094056.3755467-2-mchunara@oss.qualcomm.com/

Commit Message

Check Status Note
Subject format Proper subsystem prefix: arm64: dts: qcom:
Body present Clear rationale for voltage changes
Authorship From: Kamal Wadhwa (original author)
Signed-off-by chain Kamal Wadhwa → Monish Chunara → Pradeep P V K
Reviewed-by tags Dmitry Baryshkov, Konrad Dybcio
Link tag Present and properly formatted
Prefix ⚠️ No UPSTREAM:/FROMLIST:/BACKPORT: prefix

Files Changed

File Status Notes
arch/arm64/boot/dts/qcom/glymur-crd.dtsi Voltage adjustments for SD card regulators

Commit 2: dt-bindings: mmc: sdhci-msm: Document the Glymur compatible

Lore link: https://lore.kernel.org/all/20260703-loutish-stimulating-hummingbird-aada5e@quoll/

Commit Message

Check Status Note
Subject format Proper subsystem prefix: dt-bindings: mmc:
Body present Clear description of binding addition
Authorship From: Monish Chunara
Signed-off-by chain Monish Chunara → Pradeep P V K
Link tag Present (different message-ID format)
Prefix ⚠️ No UPSTREAM:/FROMLIST:/BACKPORT: prefix

Files Changed

File Status Notes
Documentation/devicetree/bindings/mmc/qcom,sdhci-msm.yaml Adds qcom,glymur-sdhci compatible

Notes

  • Link uses a different message-ID format (20260703-loutish-stimulating-hummingbird-aada5e@quoll) compared to the series pattern, suggesting this may be a separate posting or revision

Commit 3: arm64: dts: qcom: Add SD Card support for Glymur SoC

Lore link: https://lore.kernel.org/all/20260702094056.3755467-4-mchunara@oss.qualcomm.com/

Commit Message

Check Status Note
Subject format Proper subsystem prefix: arm64: dts: qcom:
Body present Clear description of SD card support addition
Authorship From: Monish Chunara
Co-developed-by Sachin Rathore (with matching Signed-off-by)
Signed-off-by chain Sachin Rathore → Monish Chunara → Pradeep P V K
Reviewed-by tags Dmitry Baryshkov
Link tag Present and properly formatted
Prefix ⚠️ No UPSTREAM:/FROMLIST:/BACKPORT: prefix

Files Changed

File Status Notes
arch/arm64/boot/dts/qcom/glymur.dtsi Adds sdhc_2 node with pinctrl configurations (91 lines)

Commit 4: arm64: dts: qcom: Enable SD card for Glymur CRD

Lore link: https://lore.kernel.org/all/20260702094056.3755467-5-mchunara@oss.qualcomm.com/

Commit Message

Check Status Note
Subject format Proper subsystem prefix: arm64: dts: qcom:
Body present Clear description of CRD enablement
Authorship From: Monish Chunara
Co-developed-by Sachin Rathore (with matching Signed-off-by)
Signed-off-by chain Sachin Rathore → Monish Chunara → Pradeep P V K
Reviewed-by tags Dmitry Baryshkov
Link tag Present and properly formatted
Prefix ⚠️ No UPSTREAM:/FROMLIST:/BACKPORT: prefix

Files Changed

File Status Notes
arch/arm64/boot/dts/qcom/glymur-crd.dts Enables sdhc_2 with regulators and card detection (24 lines)

qcom-next Presence

Searched /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel (origin/qcom-next):

Commit Status
arm64: dts: qcom: glymur-crd: Update VREG l2b_e0 and l9b_e0 voltage for SD-card ⚠️ Not found in qcom-next
dt-bindings: mmc: sdhci-msm: Document the Glymur compatible ⚠️ Not found in qcom-next
arm64: dts: qcom: Add SD Card support for Glymur SoC ⚠️ Not found in qcom-next
arm64: dts: qcom: Enable SD card for Glymur CRD ⚠️ Not found in qcom-next

Issues Found

  1. Missing commit prefix (all 4 commits): No UPSTREAM:, FROMLIST:, BACKPORT:, or QCLINUX: prefix in subject lines. Based on the presence of lore.kernel.org links and Reviewed-by tags from upstream maintainers (Dmitry Baryshkov, Konrad Dybcio), these appear to be patches posted to upstream mailing lists. Expected prefix: FROMLIST: (if pending upstream) or UPSTREAM: (if already merged upstream).

  2. Commit 2 message-ID mismatch: Commit 2 uses a different message-ID format (20260703-loutish-stimulating-hummingbird-aada5e@quoll) compared to commits 1, 3, 4 which follow the series pattern (20260702094056.3755467-N-mchunara@oss.qualcomm.com). This suggests commit 2 may be from a different posting or revision.

  3. Cannot verify diff content: Due to network restrictions, cannot fetch upstream patches to verify that PR diffs match lore patches exactly. Manual verification recommended.

  4. Cannot verify upstream status: Cannot determine if patches have been ACKed, NACKed, or are still pending on the mailing list.


Verdict

⏭️ PARTIAL VALIDATION - Commit message structure and authorship are correct, but critical validation steps are blocked:

What was verified (✅):

  • All 4 commits have lore.kernel.org links
  • Commit message format follows kernel conventions
  • Authorship and Signed-off-by chains are correct
  • Co-developed-by tags properly formatted
  • Reviewed-by tags from upstream maintainers present
  • Files changed are appropriate for the described changes

What could not be verified (⚠️):

  • Diff content faithfulness to upstream lore patches
  • Upstream patch acceptance status (ACKed/NACKed/Pending)
  • Whether patches have been merged to mainline/stable
  • Correct commit prefix (UPSTREAM: vs FROMLIST: vs BACKPORT:)

Recommendation:

  1. Add commit prefix: If these patches are posted upstream but not yet merged, add FROMLIST: prefix to all commit subjects. If already merged upstream, use UPSTREAM: and update Link to point to the git.kernel.org commit.
  2. Verify commit 2 message-ID: Confirm whether commit 2's different message-ID is intentional (separate posting) or should match the series pattern.
  3. Manual diff verification: Since network access is restricted, manually verify that PR diffs match the lore patches at the provided URLs.
  4. Check upstream status: Manually check lore.kernel.org threads to determine if patches have been accepted, rejected, or are still under review.

Final Summary

  1. Lore link present: Yes — all 4 commits have lore.kernel.org links in Link: tags
  2. Lore link matches PR commits: Cannot verify — network restricted, unable to fetch upstream patches for comparison
  3. Upstream patch status: Cannot verify — network restricted, unable to check mailing list threads or git trees for acceptance status
  4. PR present in qcom-next: No — none of the 4 commits found in origin/qcom-next (searched by subject)

@qlijarvis

Copy link
Copy Markdown

PR #1466 — checker-log-analyzer

PR: #1466
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28646678401

Checker Result Summary
Checker Result Summary
checkpatch CI infrastructure failure - merge conflict
dt-binding-check CI infrastructure failure - merge conflict
dtb-check CI infrastructure failure - merge conflict
sparse-check CI infrastructure failure - merge conflict
check-uapi-headers CI infrastructure failure - merge conflict
check-patch-compliance CI infrastructure failure - merge conflict
tag-check All 4 commits missing required subject prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1466 - Add SD Card support for Glymur SoC
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/28646678401

Checker Result Summary
checkpatch CI infrastructure failure - merge conflict
dt-binding-check CI infrastructure failure - merge conflict
dtb-check CI infrastructure failure - merge conflict
sparse-check CI infrastructure failure - merge conflict
check-uapi-headers CI infrastructure failure - merge conflict
check-patch-compliance CI infrastructure failure - merge conflict
tag-check All 4 commits missing required subject prefix

❌ CI Infrastructure Failure (All Checkers)

Root cause: The topic branch topic/tech/all/dt/glymur has no common git history with the baseline integration branch, causing git to refuse the merge with "refusing to merge unrelated histories".

Failure details:

Merging topic branch: topic/tech/all/dt/glymur
fatal: refusing to merge unrelated histories
Merge failed, manual merge
##[error]Process completed with exit code 3

This error occurred identically in all 6 checker jobs:

  • checkpatch (exit code 3)
  • dt-binding-check (exit code 3)
  • dtb-check (exit code 3)
  • sparse-check (exit code 3)
  • check-uapi-headers (exit code 3)
  • check-patch-compliance (exit code 3)

Analysis:

The CI workflow attempts to:

  1. Create an integration branch based on baseline tag 19b282f417584cfe14ce6a262122c51553d026ec
  2. Merge the topic branch topic/tech/all/dt/glymur
  3. Then merge PR Topic/glymur sdcard dt v2 #1466 on top

However, the topic branch tech/all/dt/glymur appears to be an orphan branch (created with --orphan or has no shared commit history with the baseline). Git refuses to merge branches with completely unrelated histories by default.

Fix:

This is a repository structure issue, not a patch defect. The topic branch needs to be rebased onto the baseline or recreated with proper ancestry. Options:

  1. Rebase the topic branch (recommended):

    git checkout tech/all/dt/glymur
    git rebase 19b282f417584cfe14ce6a262122c51553d026ec
    git push --force-with-lease origin tech/all/dt/glymur
  2. Force merge with --allow-unrelated-histories (if the CI workflow supports it):

    git merge --allow-unrelated-histories topic/tech/all/dt/glymur
  3. Recreate the topic branch with proper ancestry:

    git checkout -b tech/all/dt/glymur-new 19b282f417584cfe14ce6a262122c51553d026ec
    git cherry-pick <commits-from-old-branch>

Note: This is a one-time setup issue for the tech/all/dt/glymur topic branch. Once fixed, future PRs targeting this topic will work correctly.


❌ tag-check

Root cause: All 4 commits in the PR are missing the required subject-line prefix tag.

Failure details:

The following commits have no prefix:

  1. arm64: dts: qcom: glymur-crd: Update VREG l2b_e0 and l9b_e0 voltage for SD-card
  2. dt-bindings: mmc: sdhci-msm: Document the Glymur compatible
  3. arm64: dts: qcom: Add SD Card support for Glymur SoC
  4. arm64: dts: qcom: Enable SD card for Glymur CRD

Analysis:

Based on the PR context:

  • Repository: qualcomm-linux/kernel-topics
  • Target: topic branch tech/all/dt/glymur (not qcom-next or qcom-next-staging)
  • All commits have Link: trailers pointing to lore.kernel.org

Since the target branch is not qcom-next or qcom-next-staging, every commit must start with one of these prefixes:

  • FROMLIST: - Posted to mailing list
  • FROMGIT: - From maintainer tree
  • UPSTREAM: - Merged into mainline
  • BACKPORT: - Backported with modifications
  • QCLINUX: - Vendor-only
  • PENDING: - Work-in-progress
  • WORKAROUND: - Temporary fix

Given that all commits have lore.kernel.org links, they should use FROMLIST: prefix.

Fix:

Rebase and amend each commit to add the FROMLIST: prefix:

git rebase -i HEAD~4

# For each commit, mark as 'reword' or 'edit', then:
git commit --amend -m "FROMLIST: arm64: dts: qcom: glymur-crd: Update VREG l2b_e0 and l9b_e0 voltage for SD-card"
# ... repeat for all 4 commits

git rebase --continue

Expected commit subjects after fix:

  1. FROMLIST: arm64: dts: qcom: glymur-crd: Update VREG l2b_e0 and l9b_e0 voltage for SD-card
  2. FROMLIST: dt-bindings: mmc: sdhci-msm: Document the Glymur compatible
  3. FROMLIST: arm64: dts: qcom: Add SD Card support for Glymur SoC
  4. FROMLIST: arm64: dts: qcom: Enable SD card for Glymur CRD

Verdict

2 blockers must be fixed before merge:

  1. CI Infrastructure: The tech/all/dt/glymur topic branch must be rebased onto the baseline to establish proper git ancestry. This is a one-time repository setup issue.

  2. Subject Prefixes: All 4 commits must be amended to add the FROMLIST: prefix to their subject lines (assuming the target branch is not qcom-next or qcom-next-staging).

Note: The actual patch content could not be validated by the checkers due to the merge failure. Once the topic branch ancestry issue is resolved, re-trigger the CI to validate:

  • checkpatch (coding style)
  • dt-binding-check (YAML schema validation)
  • dtb-check (compiled DTB validation)
  • sparse-check (static analysis)
  • check-uapi-headers (ABI compatibility)
  • check-patch-compliance (upstream link & author verification)

QUIC-kamalw and others added 4 commits July 3, 2026 14:53
… voltage for SD-card

SD cards may need 1.8v VDDIO also to be supported, to accommodate this
requirement reduce the min voltage to 1.8v for `vreg_l2b_e0` which
supplies to VDDIO pin of SD card.

NOTE - Since this SD card is the only client on this regulator, this
change should not have any side effect on any other clients.
moreover, SD card driver takes care to explicitly vote for the
regulator voltage based on the SD card detection sequence.

Also for stable operation of the SD card increase VDD voltage
supplied by `vreg_l9b_e0` to 2.96v.

Signed-off-by: Kamal Wadhwa <kamal.wadhwa@oss.qualcomm.com>
Signed-off-by: Monish Chunara <monish.chunara@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Link: https://lore.kernel.org/all/20260702094056.3755467-2-mchunara@oss.qualcomm.com/
Signed-off-by: Pradeep P V K <pradeep.pragallapati@oss.qualcomm.com>
Document the Glymur-specific SDHCI compatible in the sdhci-msm binding.
Use "qcom,sdhci-msm-v5" as the fallback compatible for the MSM SDHCI v5
controller used on Glymur.

Signed-off-by: Monish Chunara <monish.chunara@oss.qualcomm.com>
Link: https://lore.kernel.org/all/20260703-loutish-stimulating-hummingbird-aada5e@quoll/
Signed-off-by: Pradeep P V K <pradeep.pragallapati@oss.qualcomm.com>
Add support for SD card on Glymur SoC and enable the required pinctrl
configurations.

Co-developed-by: Sachin Rathore <sachin.rathore@oss.qualcomm.com>
Signed-off-by: Sachin Rathore <sachin.rathore@oss.qualcomm.com>
Signed-off-by: Monish Chunara <monish.chunara@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://lore.kernel.org/all/20260702094056.3755467-4-mchunara@oss.qualcomm.com/
Signed-off-by: Pradeep P V K <pradeep.pragallapati@oss.qualcomm.com>
Enable SD card for Glymur CRD platform. Configure the vmmc/vqmmc
regulators and gpio-based card detection for the platform.

Co-developed-by: Sachin Rathore <sachin.rathore@oss.qualcomm.com>
Signed-off-by: Sachin Rathore <sachin.rathore@oss.qualcomm.com>
Signed-off-by: Monish Chunara <monish.chunara@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://lore.kernel.org/all/20260702094056.3755467-5-mchunara@oss.qualcomm.com/
Signed-off-by: Pradeep P V K <pradeep.pragallapati@oss.qualcomm.com>
@qcomlnxci qcomlnxci requested a review from a team July 3, 2026 09:29
@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1466

PR: #1466
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28651590629

# Error File:Line PR-introduced? Root Cause
1 Merge conflict (content) arch/arm64/boot/dts/qcom/glymur-crd.dts Yes PR modifies this file; conflicts with concurrent changes in base branch
2 Merge conflict (content) arch/arm64/boot/dts/qcom/glymur-crd.dtsi Yes PR modifies this file; conflicts with concurrent changes in base branch
3 Merge conflict (content) arch/arm64/boot/dts/qcom/glymur.dtsi Yes PR modifies this file; conflicts with concurrent changes in base branch
4-106 Merge conflicts (various) 103 other files No Pre-existing integration conflicts unrelated to PR changes

Verdict

3 of 106 merge conflicts are introduced by this PR; 103 are pre-existing integration issues in the base branch.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1466

PR: #1466
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28651590629

# Error File:Line PR-introduced? Root Cause
1 Merge conflict (content) arch/arm64/boot/dts/qcom/glymur-crd.dts Yes PR adds SD card node that conflicts with other changes in baseline
2 Merge conflict (content) arch/arm64/boot/dts/qcom/glymur-crd.dtsi Yes PR modifies regulator voltages (vreg_l2b_e0, vreg_l9b_e0) that conflict with baseline
3 Merge conflict (content) arch/arm64/boot/dts/qcom/glymur.dtsi Yes PR adds sdhc_2 node and pinctrl states that conflict with baseline
4 Merge conflict (add/add) Documentation/devicetree/bindings/cpufreq/qcom,shikra-epss.yaml No Pre-existing conflict unrelated to PR changes
5 Merge conflict (content) Multiple files (96 total conflicts) No Pre-existing conflicts in unrelated subsystems (media, interconnect, drivers, etc.)

Verdict

3 of 99 merge conflicts are directly introduced by this PR's changes to Glymur device tree files; 96 are pre-existing conflicts in the integration branch unrelated to the PR.

📎 Detailed analysis: Full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants