scsi: ufs: test change

[nitinrawat123]

This is test change***

Change-Id: Ic9b9e7c144f040aa7ca9c85f668df0bcfd0d4fa5

[qlijarvis]

🔨 Build Failure Analysis — PR #1465

PR: #1465
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28644279148

#	Error	File:Line	PR-introduced?	Root Cause
N/A	Merge conflicts (106 files)	Multiple files	No	Pre-existing integration conflicts between topic branches during automerge

Verdict

This is not a compilation failure. The build failed during the automerge phase due to 106 merge conflicts between the PR's target branch (tech/storage/all) and the baseline (qcom-next). The PR change itself (drivers/ufs/host/ufs-qcom.c) is syntactically valid and would compile successfully if the merge conflicts were resolved.

📎 Detailed analysis: Full report

[qlijarvis]

🔨 Build Failure Analysis — PR #1465

PR: #1465
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28644279148

#	Error	File:Line	PR-introduced?	Root Cause
N/A	Merge conflict during integration	Multiple files (101 conflicts)	No	Pre-existing integration conflicts unrelated to PR changes

Verdict

This PR introduces zero compilation errors. The build failure is caused by 101 pre-existing merge conflicts during the automerge/integration phase when merging the topic/tech/storage/all branch into the integration baseline. The PR's single change to drivers/ufs/host/ufs-qcom.c merged cleanly without conflicts.

📎 Detailed analysis: Full report

[qlijarvis]

PR #1465 — validate-patch

PR: #1465

Verdict	Issues	Detailed Report
❌	0	Full report

Final Summary

1. Lore link present: No — no lore.kernel.org link found in commit message or trailers; no vendor prefix to indicate this is intentionally vendor-only
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: N/A — no upstream reference; appears to be unintentional test commit
4. PR present in qcom-next: Not checked — commit lacks proper attribution and appears to be test code that should not be merged

Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #1465 - scsi: ufs: test change
Upstream commit: (none found)
Verdict: ❌ FAIL

Commit Message

Check	Status	Note
Subject matches upstream	❌	No upstream reference found
Body preserves rationale	❌	Body contains only test placeholder text
Fixes tag present/correct	❌	No Fixes tag present
Authorship preserved	N/A	No upstream to compare against
Backport note (if applicable)	N/A	Not a backport

Diff

File	Status	Notes
drivers/ufs/host/ufs-qcom.c	❌	Adds debug pr_err() with test message; no upstream justification

Issues

1. No lore.kernel.org link found — The commit message contains no Link: tag, no Patch-mainline: tag, and no lore.kernel.org URL in the body or trailers.

2. Missing vendor prefix — The commit subject lacks a required prefix (UPSTREAM:, FROMLIST:, BACKPORT:, QCLINUX:, PENDING:, WORKAROUND:) to indicate the patch's origin and status.

3. Inadequate commit message — The body contains only placeholder text ("This is test change***") with no technical rationale, problem description, or justification for the change.

4. Debug code in production — The patch adds pr_err(" this is test change\n"); which appears to be debug/test code rather than a legitimate fix or feature.

5. Whitespace issue — The added code uses spaces instead of tabs for indentation, inconsistent with kernel coding style.

6. Change-Id present — The commit contains a Gerrit Change-Id which should be removed before submission to upstream-oriented trees.

Verdict

Do not merge. This commit appears to be a test/debug change that was not intended for production. It lacks:

• Any upstream reference or vendor prefix
• A meaningful commit message explaining the purpose
• Legitimate code changes (adds only a test pr_err statement)

This should either be:

• Dropped entirely if it was a test commit
• Reworked with proper justification and prefix if it represents legitimate work
• Marked with QCLINUX: prefix if it's intentionally vendor-only (though the test nature suggests it should be dropped)

Final Summary

1. Lore link present: No — no lore.kernel.org link found in commit message or trailers; no vendor prefix to indicate this is intentionally vendor-only
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: N/A — no upstream reference; appears to be unintentional test commit
4. PR present in qcom-next: Not checked — commit lacks proper attribution and appears to be test code that should not be merged

[qlijarvis]

PR #1465 — checker-log-analyzer

PR: #1465
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28644279450

Checker	Result	Summary
Checker	Result	Summary
checkpatch	❌	2 errors, 1 warning: Gerrit Change-Id, indentation issues
dt-binding-check	⏭️	No DT binding changes
dtb-check	⏭️	No devicetree changes
sparse-check	✅	Passed
check-uapi-headers	✅	Passed
check-patch-compliance	❌	Missing required subject prefix
tag-check	❌	Subject missing required prefix (target: topic/tech/storage/all)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1465 - scsi: ufs: test change
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/28644279450

Checker	Result	Summary
checkpatch	❌	2 errors, 1 warning: Gerrit Change-Id, indentation issues
dt-binding-check	⏭️	No DT binding changes
dtb-check	⏭️	No devicetree changes
sparse-check	✅	Passed
check-uapi-headers	✅	Passed
check-patch-compliance	❌	Missing required subject prefix
tag-check	❌	Subject missing required prefix (target: topic/tech/storage/all)

---

❌ checkpatch

Root cause: Commit contains Gerrit Change-Id and uses spaces instead of tabs for indentation.

Failure details:

Commit f7cfe68f7ac4 ("scsi: ufs: test change")

ERROR: Remove Gerrit Change-Id's before submitting upstream
#8: 
Change-Id: Ic9b9e7c144f040aa7ca9c85f668df0bcfd0d4fa5

ERROR: code indent should use tabs where possible
#22: FILE: drivers/ufs/host/ufs-qcom.c:2956:
+        pr_err(" this is test change\n");$

WARNING: please, no spaces at the start of a line
#22: FILE: drivers/ufs/host/ufs-qcom.c:2956:
+        pr_err(" this is test change\n");$

f7cfe68f7ac4631a5f0083538de4a1663bdd83fa total: 2 errors, 1 warnings, 0 checks, 8 lines checked

Fix:

1. Remove the Change-Id: line from the commit message
2. Replace spaces with tabs for code indentation in drivers/ufs/host/ufs-qcom.c:2956

git rebase -i <base_sha>   # mark commit f7cfe68f7ac4 as 'edit'

# Edit the commit message to remove Change-Id line
git commit --amend

# Fix the indentation in the file
sed -i 's/^        pr_err/\tpr_err/' drivers/ufs/host/ufs-qcom.c
git add drivers/ufs/host/ufs-qcom.c
git commit --amend --no-edit

git rebase --continue

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git 19b282f417584cfe14ce6a262122c51553d026ec..562a503dd6712797e77ade09aac7083a0c233e5d

---

❌ check-patch-compliance

Root cause: Commit subject line does not start with a required prefix (FROMLIST:, FROMGIT:, UPSTREAM:, or BACKPORT:).

Failure details:

Checking commit: scsi: ufs: test change
Commit summary does not start with a required prefix

Fix:
The commit subject scsi: ufs: test change must be prefixed with one of the allowed tags. Choose based on the patch origin:

• If posted to lore.kernel.org → use FROMLIST:
• If from a maintainer git tree → use FROMGIT:
• If merged into mainline → use UPSTREAM:
• If backported with modifications → use BACKPORT:

git rebase -i <base_sha>   # mark commit as 'reword'
# Change subject to: "FROMLIST: scsi: ufs: test change" (or appropriate prefix)
git rebase --continue

If this is a vendor-only test change with no upstream equivalent, note that QCLINUX: and PENDING: prefixes are not accepted by check-patch-compliance — this is a known checker limitation.

Reproduce locally:

bash ../kernel-checkers/check-patch-compliance.sh --kernel-src . --base <base_sha> --head <head_sha>

---

❌ tag-check

Root cause: Commit subject missing required prefix tag (target branch is topic/tech/storage/all, not qcom-next or qcom-next-staging).

Failure details:

Commit f7cfe68f7ac4 ("scsi: ufs: test change"): subject line does not start with a required prefix.

All branches except qcom-next and qcom-next-staging require one of:
FROMLIST: / FROMGIT: / UPSTREAM: / BACKPORT: / QCLINUX: / PENDING: / WORKAROUND:

Fix:
Since the target branch is topic/tech/storage/all (not qcom-next or qcom-next-staging), every commit must start with a valid prefix tag.

git rebase -i <base_sha>   # mark commit as 'reword'
# Change subject to include appropriate prefix:
#   - FROMLIST: scsi: ufs: test change  (if posted to lore)
#   - UPSTREAM: scsi: ufs: test change  (if merged to mainline)
#   - QCLINUX: scsi: ufs: test change   (if vendor-only)
git rebase --continue

Choose the correct prefix based on patch origin:

• Posted to lore but not yet merged → FROMLIST:
• In a maintainer tree → FROMGIT:
• Merged into Linus's tree → UPSTREAM:
• Backported with modifications → BACKPORT:
• Vendor-only, no upstream → QCLINUX:
• Work-in-progress, not posted → PENDING:
• Temporary fix → WORKAROUND:

---

Verdict

3 blockers must be fixed before merge:

1. checkpatch — Remove Gerrit Change-Id and fix indentation (use tabs, not spaces)
2. check-patch-compliance — Add required subject prefix (FROMLIST:, UPSTREAM:, etc.)
3. tag-check — Same as dummy change #2 (subject prefix is mandatory for non-qcom-next branches)

All three issues can be resolved in a single git rebase -i session by:

• Removing the Change-Id: line from the commit message
• Adding the appropriate prefix to the subject line
• Fixing the indentation in drivers/ufs/host/ufs-qcom.c