Skip to content

FROMLIST: arm64: dts: qcom: purwa-evk: add DP0/DP1 audio playback support#1447

Open
QTI-Quill wants to merge 1 commit into
qualcomm-linux:tech/all/dt/hamoafrom
QTI-Quill:tech/all/dt/hamoa
Open

FROMLIST: arm64: dts: qcom: purwa-evk: add DP0/DP1 audio playback support#1447
QTI-Quill wants to merge 1 commit into
qualcomm-linux:tech/all/dt/hamoafrom
QTI-Quill:tech/all/dt/hamoa

Conversation

@QTI-Quill

Copy link
Copy Markdown

The purwa-evk DTS currently lacks DAI links for DP0 and DP1, preventing the sound card from exposing these playback paths. Add the missing links to enable audio output on both DP interfaces.

This change follows the same approach as the fix for hamoa-evk.

Link: https://lore.kernel.org/all/20260210024037.3719191-1-le.qi@oss.qualcomm.com/
Link: https://lore.kernel.org/all/20260701063003.3082899-1-le.qi@oss.qualcomm.com/

…port

The purwa-evk DTS currently lacks DAI links for DP0 and DP1, preventing
the sound card from exposing these playback paths. Add the missing links
to enable audio output on both DP interfaces.

This change follows the same approach as the fix for hamoa-evk.

Link: https://lore.kernel.org/all/20260210024037.3719191-1-le.qi@oss.qualcomm.com/
Link: https://lore.kernel.org/all/20260701063003.3082899-1-le.qi@oss.qualcomm.com/
Signed-off-by: Le Qi <le.qi@oss.qualcomm.com>
@qcomlnxci qcomlnxci requested review from a team, aiquny, Amit Kucheria (idlethread) and Tingwei Zhang (quic-tingweiz) and removed request for a team July 1, 2026 07:15
@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1447

PR: #1447
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28500368681

# Error File:Line PR-introduced? Root Cause
1 Merge conflict (add/add) Documentation/devicetree/bindings/cpufreq/qcom,shikra-epss.yaml No Pre-existing conflict between baseline (qcom-next) and target branch (tech/all/dt/hamoa)
2 Merge conflict (content) Documentation/devicetree/bindings/crypto/qcom,prng.yaml No Pre-existing conflict between baseline and target branch
3 Merge conflict (content) Documentation/devicetree/bindings/crypto/qcom-qce.yaml No Pre-existing conflict between baseline and target branch
4 Merge conflict (content) Documentation/devicetree/bindings/display/msm/gpu.yaml No Pre-existing conflict between baseline and target branch
5 Merge conflict (add/add) Documentation/devicetree/bindings/interconnect/qcom,shikra.yaml No Pre-existing conflict between baseline and target branch
6-101 96 additional merge conflicts Various files (DT bindings, drivers, includes) No Pre-existing conflicts between baseline and target branch

Verdict

All 101 merge conflicts are pre-existing integration issues between the baseline branch (qcom-next) and the target branch (tech/all/dt/hamoa). None are introduced by this PR. The PR file (arch/arm64/boot/dts/qcom/purwa-iot-evk.dts) was successfully auto-merged without conflicts.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1447

PR: #1447
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28500368681

# Error File:Line PR-introduced? Root Cause
1 Merge conflict during automerge Documentation/devicetree/bindings/cpufreq/qcom,shikra-epss.yaml No Pre-existing integration conflict between baseline (qcom-next) and topic branch (tech/all/dt/hamoa). Both branches independently created the same file.

Verdict

This is not a compilation error. The build failed during the pre-merge integration phase due to a merge conflict in a file unrelated to this PR. The PR only modifies arch/arm64/boot/dts/qcom/purwa-iot-evk.dts and does not introduce any compilation errors.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

PR #1447 — validate-patch

PR: #1447

Verdict Issues Detailed Report
⚠️ 3 Full report

Final Summary

  1. Lore link present: Yes - two links provided (first is reference hamoa-evk patch, second should be purwa-evk submission)
  2. Lore link matches PR commits: Cannot verify - network restrictions prevent fetching purwa-evk lore patch for comparison
  3. Upstream patch status: In review - FROMLIST prefix indicates posted to mailing list but not yet merged; cannot verify posting due to network restrictions
  4. PR present in qcom-next: No - not found in qcom-next branch; this is a new submission
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1447 - arm64: dts: qcom: purwa-evk: add DP0/DP1 audio playback support
Upstream commit: https://lore.kernel.org/all/20260701063003.3082899-1-le.qi@oss.qualcomm.com/ (cannot verify - network restricted)
Verdict: ⚠️ PARTIAL

Commit Message

Check Status Note
Subject matches upstream ⚠️ Uses lowercase "add" vs upstream hamoa used "Add"; otherwise follows pattern
Body preserves rationale Clear rationale explaining missing DAI links; includes reference to hamoa-evk
Fixes tag present/correct N/A Not a fix; new feature addition
Authorship preserved Le Qi le.qi@oss.qualcomm.com - same author as hamoa-evk patch
Backport note (if applicable) N/A FROMLIST prefix indicates pending upstream submission

Diff

File Status Notes
arch/arm64/boot/dts/qcom/purwa-iot-evk.dts Identical structure to upstream hamoa-evk patch; adds dp0-dai-link and dp1-dai-link nodes

Issues

  • Subject capitalization: Uses lowercase "add" instead of "Add" (upstream hamoa commit used "Add DP0/DP1 audio playback support")
  • First lore link: Points to hamoa-evk patch (20260210024037.3719191-1) as reference, not the actual purwa-evk upstream submission
  • Extra context line: "This change follows the same approach as the fix for hamoa-evk." is helpful but not typical for upstream commit messages (usually omitted in favor of concise rationale)
  • Cannot verify upstream status: Network restrictions prevent fetching second lore link (20260701063003.3082899-1) to confirm patch was actually posted upstream

Verdict

Merge with minor subject capitalization fix recommended. Diff is correct and follows established hamoa-evk pattern. Commit message is clear but has minor style inconsistency.

Final Summary

  1. Lore link present: Yes - two links provided (first is reference hamoa-evk patch, second should be purwa-evk submission)
  2. Lore link matches PR commits: Cannot verify - network restrictions prevent fetching purwa-evk lore patch for comparison
  3. Upstream patch status: In review - FROMLIST prefix indicates posted to mailing list but not yet merged; cannot verify posting due to network restrictions
  4. PR present in qcom-next: No - not found in qcom-next branch; this is a new submission

@qlijarvis

Copy link
Copy Markdown

PR #1447 — checker-log-analyzer

PR: #1447
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28500368314

Checker Result Summary
Checker Result Summary
checkpatch ⏭️ CI infrastructure failure - no checker execution
dt-binding-check ⏭️ CI infrastructure failure - no checker execution
dtb-check ⏭️ CI infrastructure failure - no checker execution
sparse-check ⏭️ CI infrastructure failure - no checker execution
check-uapi-headers ⏭️ CI infrastructure failure - no checker execution
check-patch-compliance ⏭️ CI infrastructure failure - no checker execution
tag-check N/A Not executed due to infrastructure failure
qcom-next-check FROMLIST: prefix present

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1447 - FROMLIST: arm64: dts: qcom: purwa-evk: add DP0/DP1 audio playback support
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/28500368314

Checker Result Summary
checkpatch ⏭️ CI infrastructure failure - no checker execution
dt-binding-check ⏭️ CI infrastructure failure - no checker execution
dtb-check ⏭️ CI infrastructure failure - no checker execution
sparse-check ⏭️ CI infrastructure failure - no checker execution
check-uapi-headers ⏭️ CI infrastructure failure - no checker execution
check-patch-compliance ⏭️ CI infrastructure failure - no checker execution
tag-check N/A Not executed due to infrastructure failure
qcom-next-check FROMLIST: prefix present

❌ CI Infrastructure Failure (All Checkers)

Root cause: Git merge failure during CI setup phase - "fatal: refusing to merge unrelated histories"

Failure details:

2026-07-01T07:32:11.2698739Z  ** Merging topic branch: topic/tech/all/dt/hamoa
2026-07-01T07:32:29.6802541Z fatal: refusing to merge unrelated histories
2026-07-01T07:32:29.7869160Z Merge failed, manual merge
...
2026-07-01T07:32:30.7966672Z Merging pr-1447 (no-commit)...
2026-07-01T07:32:50.6539218Z fatal: refusing to merge unrelated histories
2026-07-01T07:32:50.7638166Z Merge failed or conflicts detected. Aborting merge.

The CI workflow failed during the repository setup phase before any actual code quality checks could run. The workflow attempts to:

  1. Create an integration branch based on baseline tag 19b282f417584cfe14ce6a262122c51553d026ec
  2. Merge the base branch tech/all/dt/hamoa into the integration branch
  3. Merge PR FROMLIST: arm64: dts: qcom: purwa-evk: add DP0/DP1 audio playback support #1447 on top

Both merge operations failed with "refusing to merge unrelated histories", indicating the base branch and the baseline tag do not share a common git history. This is a CI configuration or repository structure issue, not a problem with the PR code itself.

Fix:

This is a CI infrastructure issue that requires one of the following actions:

  1. Repository maintainer action: Verify that the base branch tech/all/dt/hamoa is properly rebased on or descended from the baseline tag used by the CI system
  2. CI configuration fix: Update the CI workflow to use --allow-unrelated-histories flag if the branch structure intentionally has separate histories
  3. Branch structure fix: Ensure the topic branch tech/all/dt/hamoa shares git history with the mainline kernel baseline

PR author action: The PR code itself appears valid (adds DP0/DP1 DAI links to purwa-iot-evk.dts with proper FROMLIST: prefix and lore links). Request that repository maintainers:

  • Re-trigger the CI after fixing the base branch history issue, OR
  • Manually review and merge the PR if the code changes are acceptable

Reproduce locally:
This cannot be reproduced locally as it's a CI infrastructure issue. However, you can verify the PR code quality manually:

# Clone the repo and checkout the PR
git fetch origin pull/1447/head:pr-1447
git checkout pr-1447

# Run checkpatch on the commit
./scripts/checkpatch.pl -g HEAD

# Verify DT bindings (if dt-schema is installed)
make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/sound/
make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/sound/

Verdict

CI infrastructure failure prevented all code quality checks from executing. The PR cannot be evaluated for code quality issues until the base branch history conflict is resolved. The PR code itself (adding DP0/DP1 audio DAI links) appears straightforward and follows proper FROMLIST conventions with upstream lore links.

Recommended action: Repository maintainers should fix the branch history issue and re-run the CI, or manually review the simple devicetree addition if the changes are acceptable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants