Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions src/quads_lib/quads.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,6 @@ def register(self) -> dict:
return json_response

def login(self) -> dict:
if self.token and self.token.startswith("qat_"):
return {
"status_code": 201,
"status": "success",
"message": "Authenticated via API token",
"auth_token": self.token,
}
endpoint = urljoin(self.base_url, "login")
_response = self.session.post(endpoint, auth=self.auth, verify=self.verify)
json_response = _response.json()
Expand Down
17 changes: 4 additions & 13 deletions tests/test_quads.py
Original file line number Diff line number Diff line change
Expand Up @@ -2083,20 +2083,11 @@ def test_init_without_api_token(self):
assert api.token is None
assert api.auth is not None

def test_login_noop_with_qat_token(self):
"""Test that login() returns synthetic success for qat_ tokens"""
def test_api_token_skips_login(self):
"""Test that api_token users should not call login() - token is already on the session"""
api = QuadsApi("", "", "http://example.com/", api_token="qat_abc123")
result = api.login()
assert result["status_code"] == 201
assert result["status"] == "success"
assert result["auth_token"] == "qat_abc123"

def test_login_noop_does_not_make_request(self):
"""Test that login() with qat_ token makes no HTTP request"""
api = QuadsApi("", "", "http://example.com/", api_token="qat_abc123")
api.session.post = Mock(side_effect=AssertionError("should not be called"))
result = api.login()
assert result["status"] == "success"
assert api.token == "qat_abc123"
assert api.session.headers.get("Authorization") == "Bearer qat_abc123"

@patch("requests.Session.request")
def test_get_user(self, mock_request):
Expand Down
Loading