Add bindings for update_vector_data and update_matrix_data.#4
Open
JonasBreuling wants to merge 2 commits intoqoco-org:mainfrom
Open
Add bindings for update_vector_data and update_matrix_data.#4JonasBreuling wants to merge 2 commits intoqoco-org:mainfrom
JonasBreuling wants to merge 2 commits intoqoco-org:mainfrom
Conversation
Member
|
Looks good, but can you add some unit tests to test out the new update functions? |
govindchari
reviewed
Mar 6, 2026
| Gxnew_ptr = (QOCOFloat *)buf.ptr; | ||
| } | ||
|
|
||
| return qoco_update_matrix_data(this->_solver, Pxnew_ptr, Axnew_ptr, Gxnew_ptr); |
Member
There was a problem hiding this comment.
Can you remove the return here since the qoco_update_matrix_data() function is void. Same with the update_vector_data()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds python bindings for update_vector_data and update_matrix_data. It depends on qoco-org/qoco#44 since minor changes to the C-code are required.