Repository navigation
Conversation
FanWu-ai
marked this pull request as ready for review
October 4, 2026 08:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The typed numeric cache key for
1is currently the ordinary tuple(int, 1). A user-provided tuple with that value therefore aliases the cached number:The reverse comparison is also missed. DeepHash lookups and public key iteration can conflate the same distinct objects.
Fix
The change is limited to
deephash.py, one safe-import entry for its inert marker inserialization.py, and regression tests. It does not change the serialized hash content of ordinary numeric inputs or numeric-equivalence behavior withignore_numeric_type_changes=True. Ordinary tuple keys now remain intact in public key iteration with either flag value.Validation
devand pass after the fix.pytest --cov=deepdiff --cov-report=term-missing --runslow --benchmark-disable: 1,329 passed, 8 skipped, 95% overall coverage (98% for deephash.py).git diff --check: passed. Full touched-file lint introduces no new diagnostics.Compatibility note
Numeric entries in raw
.hashesdictionaries use a new key shape. Such dictionaries retained from older versions should be rebuilt. Public object-based lookup remains unchanged.