Skip to content

feat(sandbox): expose sandbox resource APIs - #458

Open
DROWNING2003 wants to merge 1 commit into
qiniu:masterfrom
DROWNING2003:feat/sandbox-resources
Open

feat(sandbox): expose sandbox resource APIs#458
DROWNING2003 wants to merge 1 commit into
qiniu:masterfrom
DROWNING2003:feat/sandbox-resources

Conversation

@DROWNING2003

Copy link
Copy Markdown
Contributor

Summary

  • expose sandbox resource listing and Git repository token updates
  • support inline Kodo credentials and typed template build disk size

Validation

  • npm run test:sandbox
  • npm run check-type

Expose sandbox resource management and support inline Kodo credentials. Add typed template disk size configuration and regression coverage.
@qiniu-prow qiniu-prow Bot added the size/L label Sep 9, 2026
@codecov

codecov Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.01%. Comparing base (32685e9) to head (3ada9d8).
⚠️ Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
qiniu/sandbox/client.js 70.00% 6 Missing ⚠️
qiniu/sandbox/sandbox.js 50.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #458      +/-   ##
==========================================
- Coverage   93.41%   93.01%   -0.41%     
==========================================
  Files          14       14              
  Lines        2006     2120     +114     
==========================================
+ Hits         1874     1972      +98     
- Misses        132      148      +16     
Files with missing lines Coverage Δ
qiniu/sandbox/sandbox.js 91.66% <50.00%> (-0.99%) ⬇️
qiniu/sandbox/client.js 94.02% <70.00%> (-2.97%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the complete fixed diff for sandbox resource APIs, inline Kodo credential handling, template build disk-size typing, and their callers/tests. I found no actionable correctness, compatibility, security, or reliability regression introduced by this PR. Inline Kodo credentials correctly avoid requiring Qiniu MAC signing, while credential-less Kodo resources retain the existing Qiniu-authenticated path; the new resource methods and facade delegation are consistent with the surrounding API patterns.

Verification note: the requested local checks could not run because the installed mocha and tsc executables are unavailable/non-executable in this workspace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant