Repository navigation
chore(SEC-41): run the release job in the release environment - #248
Merged
Merged
Conversation
Davidonium
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of SEC-41 / SEC-48: release jobs run in a protected
releaseenvironment, same setup as the repos already switched (operator, agent, route-manager, auth-sidecar, …).The job pauses at "waiting for review" after the push to the release ref. A code owner who is not the person who pushed opens the run, clicks Review deployments, ticks
release, and approves. Only then does the job get its secrets and OIDC token. Repo admins can bypass for incidents.Environment settings (already created): reviewers = the CODEOWNERS team, self-review blocked, deployment policy limited to the release ref pattern.
Where a workflow has several credentialed jobs, each of them is gated, so each waits for its own approval; jobs that only tag and publish release notes with
GITHUB_TOKENare not gated.Central thread: https://qdrant.slack.com/archives/C04TJ6MF88M/p1793918894034639