You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Benchmark trigger : We want benchmarks to be run via some "trigger" ideally through a Github action when a commit is merged to main. This is to detect any regression in performance caused by git commits. I believe we can take inspiration from qiskit.github.io and their workflow on how they publish these benchmarks. It doesn't need to be as extensive at first, we can target only a few machines and gradually build up from there.
Test files : Current diff is 70k+ lines just from tests! While this is okay if we want version control for the tests, but, practically speaking, these tests will not change over time. It is better to keep a metadata file for the tests and either -
Generate the files on the fly
Pull the files from a public repository / Amazon s3 bucket.
I think the second method would work better in our case as the benchpress repo is already public
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
import,load,draw,unroll,validate,dumpand ,dumps.Qubit Register ConsolidationandOpenpulseprograms.Verification Instructions:
From the project root, you can verify the benchmarks with the following steps:
Creates a benchmarking environment under .asv/.
Generates
htmloutput files containing benchmark results in tests/benchmarking/.Launches a local server to view benchmarking results in your browser.
Notes
Profiling
Profiling data and visualizations for PyQASM functions
openpulse,qubit register consolidation,unroll, andvalidateprofiling.Closes #67