Skip to content

NXP backend: added support for aten.pad with mode reflect - #21515

Open
novak-vaclav wants to merge 1 commit into
pytorch:mainfrom
nxp-upstream:feature/EIEX-888-add-pad-support
Open

NXP backend: added support for aten.pad with mode reflect#21515
novak-vaclav wants to merge 1 commit into
pytorch:mainfrom
nxp-upstream:feature/EIEX-888-add-pad-support

Conversation

@novak-vaclav

@novak-vaclav novak-vaclav commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Summary

Added support for aten.pad with mode reflect using new Neutron MLIR flow.

Test plan

tests can be manually run using pytest -c /dev/null backends/nxp/tests/

cc @robert-kalmar @JakeStevens @digantdesai @rascani @MartinPavella

Copilot AI review requested due to automatic review settings July 31, 2026 08:29
@novak-vaclav novak-vaclav added module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate labels Jul 31, 2026
@pytorch-bot

pytorch-bot Bot commented Jul 31, 2026 •
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21515

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 25 Pending

As of commit 6bf8da0 with merge base 250020b (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 31, 2026
Copilot AI reviewed Jul 31, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@linux-foundation-easycla

linux-foundation-easycla Bot commented Jul 31, 2026 •
edited
Loading

Copy link
Copy Markdown

CLA Not Signed

@novak-vaclav
novak-vaclav force-pushed the feature/EIEX-888-add-pad-support branch from 9b9736c to 97731d1 Compare July 31, 2026 09:44
Copilot AI review requested due to automatic review settings July 31, 2026 09:44
Copilot AI reviewed Jul 31, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@novak-vaclav

novak-vaclav commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator Author

Fixed minor issues I found out about after creating the PR.

@novak-vaclav
novak-vaclav force-pushed the feature/EIEX-888-add-pad-support branch from 97731d1 to 76b13f3 Compare July 31, 2026 09:52
@novak-vaclav

novak-vaclav commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator Author

And rebased onto current main to run the tests on Neutron Software 3.2.0

roman-janik-nxp
roman-janik-nxp reviewed Jul 31, 2026
View reviewed changes
Comment thread backends/nxp/backend/ir/converter/node_converters/ops_converters/pad_converter.py Outdated
Comment thread backends/nxp/backend/ir/converter/node_converters/ops_converters/pad_converter.py Outdated
Comment thread backends/nxp/neutron_partitioner.py Outdated
Comment thread backends/nxp/tests/ir/converter/node_converter/test_constant_pad_nd_converter.py Outdated
Comment thread backends/nxp/backend/ir/converter/node_converters/ops_converters/pad_converter.py
Comment thread backends/nxp/backend/ir/converter/node_converters/ops_converters/pad_converter.py Outdated
Copilot AI review requested due to automatic review settings July 31, 2026 16:11
@novak-vaclav
novak-vaclav force-pushed the feature/EIEX-888-add-pad-support branch from 76b13f3 to fc14b2c Compare July 31, 2026 16:11
Copilot AI reviewed Jul 31, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings July 31, 2026 16:19
@novak-vaclav
novak-vaclav force-pushed the feature/EIEX-888-add-pad-support branch from fc14b2c to bc44109 Compare July 31, 2026 16:19
Copilot AI reviewed Jul 31, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@novak-vaclav
novak-vaclav force-pushed the feature/EIEX-888-add-pad-support branch from bc44109 to 6bf8da0 Compare July 31, 2026 16:26
Copilot AI review requested due to automatic review settings July 31, 2026 16:26
Copilot AI reviewed Jul 31, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@novak-vaclav

novak-vaclav commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator Author

Resolved comments from code review, resolved conflicts with main and rebased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@irtrukhina irtrukhina Awaiting requested review from irtrukhina
@MartinPavella MartinPavella Awaiting requested review from MartinPavella
@jirioc jirioc Awaiting requested review from jirioc
@robert-kalmar robert-kalmar Awaiting requested review from robert-kalmar robert-kalmar is a code owner
@roman-janik-nxp roman-janik-nxp Awaiting requested review from roman-janik-nxp

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@novak-vaclav @roman-janik-nxp