Keep delegate-consumed mutable buffers above the delegate - #21507
Open
Conarnar wants to merge 1 commit into
Open
Keep delegate-consumed mutable buffers above the delegate#21507Conarnar wants to merge 1 commit into
Conarnar wants to merge 1 commit into
Conversation
Summary:
`tag_constant_data` freezes a const/param/buffer into a delegate when all of its
users are partitioned. It recognized a *mutated* buffer only when a direct user's
node name is a key in `buffers_to_mutate`. That misses the case where a buffer
both feeds a delegate and is mutated *inside* it: the mutation is produced by a
`getitem` off the `call_delegate`, so the buffer's only direct user is the
delegate node (whose name is not a `buffers_to_mutate` key), and the buffer is
wrongly frozen as constant data instead of staying a method-owned mutable buffer.
Additionally treat a placeholder as a mutated buffer when its FQN is a
`buffers_to_mutate` target, so a buffer a delegate updates in place stays owned
above the delegate. This is the case anticipated by
`test_not_delegate_mutable_buffers` ("consider when the delegate can consume the
mutable buffer") — e.g. a backend that embeds a pre-compiled engine which updates
a KV cache in place.
Authored with AI assistance (Claude Code).
Differential Revision: D114288921
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21507
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit a8bd74e with merge base 43cb2b2 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@Conarnar has exported this pull request. If you are a Meta employee, you can view the originating Diff in D114288921. |
This PR needs a
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
tag_constant_datafreezes a const/param/buffer into a delegate when all of itsusers are partitioned. It recognized a mutated buffer only when a direct user's
node name is a key in
buffers_to_mutate. That misses the case where a bufferboth feeds a delegate and is mutated inside it: the mutation is produced by a
getitemoff thecall_delegate, so the buffer's only direct user is thedelegate node (whose name is not a
buffers_to_mutatekey), and the buffer iswrongly frozen as constant data instead of staying a method-owned mutable buffer.
Additionally treat a placeholder as a mutated buffer when its FQN is a
buffers_to_mutatetarget, so a buffer a delegate updates in place stays ownedabove the delegate. This is the case anticipated by
test_not_delegate_mutable_buffers("consider when the delegate can consume themutable buffer") — e.g. a backend that embeds a pre-compiled engine which updates
a KV cache in place.
Authored with AI assistance (Claude Code).
Differential Revision: D114288921