Arm backend: Fix standalone runner link order#20756
Open
bdemirb wants to merge 2 commits into
Open
Conversation
Fix the Arm semihosting executor runner link order used by setup_testing.sh. The previous link line placed backend archives before the objects and dependent archives that reference them, so ld could miss bare-metal symbols when building the standalone runners. Group the runner libraries and keep the backend archives in a whole-archive region after clearing their inherited interface link options. This keeps symbols visible to the linker while preserving the existing runner setup. Signed-off-by: Baris Demir <baris.demir@arm.com> Change-Id: Ib1bb2e3a39a3b955556cd67847f74c6ff6d159ab
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20756
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 27 PendingAs of commit 5fde7b6 with merge base fa49f8f ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
Collaborator
Author
|
@pytorchbot label "partner: arm" |
pytorch-bot
Bot
added
the
partner: arm
Collaborator
Author
|
@pytorchbot label "release notes: arm" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the Arm semihosting executor runner link order used by setup_testing.sh. The previous link line placed backend archives before the objects and dependent archives that reference them, so ld could miss bare-metal symbols when building the standalone runners.
Group the runner libraries and keep the backend archives in a whole-archive region after clearing their inherited interface link options. This keeps symbols visible to the linker while preserving the existing runner setup.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani