Remove _use_edge_ops=True (#20516)#20516
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20516
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 2 Pending, 2 Unrelated FailuresAs of commit c5c4538 with merge base 6edd49d ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@JakeStevens has exported this pull request. If you are a Meta employee, you can view the originating Diff in D109702323. |
This PR needs a
|
|
The day finally comes! |
Summary: In preparation of removing _use_edge_ops (see TODO in _config.py for EdgeCompileConfig), removing all explicit usages where =True, since this is already the case by default. Differential Revision: D109702323
831ebe0 to
e195b91
Compare
Summary: In preparation of removing _use_edge_ops (see TODO in _config.py for EdgeCompileConfig), removing all explicit usages where =True, since this is already the case by default. Differential Revision: D109702323
e195b91 to
997c52b
Compare
Summary: In preparation of removing _use_edge_ops (see TODO in _config.py for EdgeCompileConfig), removing all explicit usages where =True, since this is already the case by default. Differential Revision: D109702323
997c52b to
782e961
Compare
Summary: In preparation of removing _use_edge_ops (see TODO in _config.py for EdgeCompileConfig), removing all explicit usages where =True, since this is already the case by default. Differential Revision: D109702323
digantdesai
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
782e961 to
5401bf3
Compare
Summary: In preparation of removing _use_edge_ops (see TODO in _config.py for EdgeCompileConfig), removing all explicit usages where =True, since this is already the case by default. Reviewed By: digantdesai Differential Revision: D109702323
Summary: In preparation of removing _use_edge_ops (see TODO in _config.py for EdgeCompileConfig), removing all explicit usages where =True, since this is already the case by default. Reviewed By: digantdesai Differential Revision: D109702323
5401bf3 to
c5c4538
Compare
Summary:
In preparation of removing _use_edge_ops (see TODO in _config.py for EdgeCompileConfig), removing all explicit usages where =True, since this is already the case by default.
Reviewed By: digantdesai
Differential Revision: D109702323