Skip to content

Allow symints to be created for arguments #16620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
per wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow symints to be created for arguments #16620

per wants to merge 1 commit into from
+112 −2

Conversation

@per
Copy link
Collaborator

@per per commented Jan 15, 2026 •
edited by pytorch-bot bot
Loading

Summary

Add test for creating args of SymInt type to be able to use them in view_copy nodes together with the fix to make the test pass.

Test plan

Tested through CI tests.

cc @freddan80 @zingo @oscarandersson8218 @digantdesai

@per
Allow symints to be created for arguments
00a24ad 
Add test for creating args of SymInt type to be able to use them
in view_copy nodes in the Arm TOSA backend together with the
fix to make the pass work.

Signed-off-by: Per Åstrand <per.astrand@arm.com>
Change-Id: Ia947b8426af1b473df415a17e10f3db1582b84fd
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 15, 2026 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16620

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 00a24ad with merge base a0ba28e (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 15, 2026
@per per requested review from SS-JIA, lucylq and ydwu4 and removed request for JacobSzwejbka and larryliu0820 January 15, 2026 10:09
@github-actions
Copy link

github-actions bot commented Jan 15, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@per per requested a review from zingo January 15, 2026 10:09
@per per added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk labels Jan 15, 2026
@zingo zingo added this to the 1.1.0 milestone Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucylq lucylq Awaiting requested review from lucylq

@ydwu4 ydwu4 Awaiting requested review from ydwu4

@SS-JIA SS-JIA Awaiting requested review from SS-JIA

@zingo zingo Awaiting requested review from zingo

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm

Projects

None yet

Milestone

1.1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@per @zingo