Skip to content

fix: restore static allocation on ResourceAllocationStrategy exit#4356

Open
cehongwang wants to merge 1 commit into
mainfrom
fix/resource-allocator-restore-static
Open

fix: restore static allocation on ResourceAllocationStrategy exit#4356
cehongwang wants to merge 1 commit into
mainfrom
fix/resource-allocator-restore-static

Conversation

@cehongwang

Copy link
Copy Markdown
Collaborator

The exit method re-applied the same dynamically_allocate_resources value used by enter, so leaving the context never restored the original (static) allocation mode as documented. Set it to False on exit and remove the leftover debug print in enter.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

The __exit__ method re-applied the same dynamically_allocate_resources
value used by __enter__, so leaving the context never restored the
original (static) allocation mode as documented. Set it to False on exit
and remove the leftover debug print in __enter__.
@meta-cla meta-cla Bot added the cla signed label Jun 21, 2026
@github-actions github-actions Bot added component: core Issues re: The core compiler component: api [Python] Issues re: Python API component: runtime component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Jun 21, 2026
@github-actions github-actions Bot requested a review from narendasan June 21, 2026 22:39

@narendasan narendasan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed component: api [Python] Issues re: Python API component: core Issues re: The core compiler component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: runtime

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants