Skip to content

fix: get CI to pass again#4351

Open
narendasan wants to merge 1 commit into
mainfrom
narendasan/push-ypqtwuuyyoqz
Open

fix: get CI to pass again#4351
narendasan wants to merge 1 commit into
mainfrom
narendasan/push-ypqtwuuyyoqz

Conversation

@narendasan

Copy link
Copy Markdown
Collaborator

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@meta-cla meta-cla Bot added the cla signed label Jun 18, 2026
@github-actions github-actions Bot added component: tests Issues re: Tests component: core Issues re: The core compiler component: build system Issues re: Build system component: api [Python] Issues re: Python API component: runtime component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Jun 18, 2026
@github-actions github-actions Bot requested a review from cehongwang June 18, 2026 21:55
@narendasan narendasan force-pushed the narendasan/push-ypqtwuuyyoqz branch from 1ae5dc2 to 7dfdbcd Compare June 22, 2026 19:41
@github-actions github-actions Bot added component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters labels Jun 22, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that do not conform to C++ style guidelines:

diff --git a/home/runner/work/TensorRT/TensorRT/core/conversion/converters/impl/conv_deconv.cpp b/tmp/changes.txt
index 83bf2b7..83b3fe7 100644
--- a/home/runner/work/TensorRT/TensorRT/core/conversion/converters/impl/conv_deconv.cpp
+++ b/tmp/changes.txt
@@ -131,8 +131,8 @@ bool add_conv_deconv(ConversionCtx* ctx, const torch::jit::Node* n, args& args)
    // the constant-weights path below for why TRT requires this.
    if (in->getType() != kernel->getType()) {
      LOG_DEBUG(
-          "Conv/deconv input type (" << in->getType() << ") differs from kernel tensor type ("
-                                     << kernel->getType() << "); casting input to match.");
+          "Conv/deconv input type (" << in->getType() << ") differs from kernel tensor type (" << kernel->getType()
+                                     << "); casting input to match.");
      in = castITensor(ctx, in, kernel->getType());
    }
    auto kernel_dims = kernel->getDimensions();
ERROR: Some files do not conform to style guidelines

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that do not conform to Python style guidelines:

--- /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/runtime/_runtime_config.py	2026-06-22 19:41:41.286873+00:00
+++ /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/runtime/_runtime_config.py	2026-06-22 19:42:05.507644+00:00
@@ -296,13 +296,11 @@
            # already materialized the underlying IRuntimeCache on ``_live``.
            wrapped = RuntimeCache(path=rc, autosave_on_del=True)
            try:
                wrapped.load()
            except Exception as e:
-                logger.warning(
-                    f"Failed to warm-load runtime cache from {rc!r}: {e}"
-                )
+                logger.warning(f"Failed to warm-load runtime cache from {rc!r}: {e}")
            cache = wrapped.ensure_cache(self._live)
            self._live.set_runtime_cache(cache)
        else:
            raise TypeError(
                f"runtime_cache must be None, str, or RuntimeCache by the "
--- /home/runner/work/TensorRT/TensorRT/tests/py/ts/api/test_classes.py	2026-06-22 19:41:41.313124+00:00
+++ /home/runner/work/TensorRT/TensorRT/tests/py/ts/api/test_classes.py	2026-06-22 19:42:11.030324+00:00
@@ -380,12 +380,10 @@
                io_key, "Neither 'I/O Tensors' nor 'Bindings' key is present"
            )
            self.assertTrue(
                len(trt_json["Layers"]) == num_layers
            ), "Not enough layers found"
-            self.assertTrue(
-                len(trt_json[io_key]) == 2, "Not enough I/O tensors found"
-            )
+            self.assertTrue(len(trt_json[io_key]) == 2, "Not enough I/O tensors found")


if __name__ == "__main__":
    unittest.main()

@narendasan narendasan force-pushed the narendasan/push-ypqtwuuyyoqz branch from 7dfdbcd to 9327d19 Compare June 22, 2026 19:48

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that do not conform to C++ style guidelines:

diff --git a/home/runner/work/TensorRT/TensorRT/core/conversion/converters/impl/conv_deconv.cpp b/tmp/changes.txt
index 83bf2b7..83b3fe7 100644
--- a/home/runner/work/TensorRT/TensorRT/core/conversion/converters/impl/conv_deconv.cpp
+++ b/tmp/changes.txt
@@ -131,8 +131,8 @@ bool add_conv_deconv(ConversionCtx* ctx, const torch::jit::Node* n, args& args)
    // the constant-weights path below for why TRT requires this.
    if (in->getType() != kernel->getType()) {
      LOG_DEBUG(
-          "Conv/deconv input type (" << in->getType() << ") differs from kernel tensor type ("
-                                     << kernel->getType() << "); casting input to match.");
+          "Conv/deconv input type (" << in->getType() << ") differs from kernel tensor type (" << kernel->getType()
+                                     << "); casting input to match.");
      in = castITensor(ctx, in, kernel->getType());
    }
    auto kernel_dims = kernel->getDimensions();
ERROR: Some files do not conform to style guidelines

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that do not conform to Python style guidelines:

--- /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/runtime/_runtime_config.py	2026-06-22 19:49:04.893010+00:00
+++ /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/runtime/_runtime_config.py	2026-06-22 19:49:26.446746+00:00
@@ -296,13 +296,11 @@
            # already materialized the underlying IRuntimeCache on ``_live``.
            wrapped = RuntimeCache(path=rc, autosave_on_del=True)
            try:
                wrapped.load()
            except Exception as e:
-                logger.warning(
-                    f"Failed to warm-load runtime cache from {rc!r}: {e}"
-                )
+                logger.warning(f"Failed to warm-load runtime cache from {rc!r}: {e}")
            cache = wrapped.ensure_cache(self._live)
            self._live.set_runtime_cache(cache)
        else:
            raise TypeError(
                f"runtime_cache must be None, str, or RuntimeCache by the "
--- /home/runner/work/TensorRT/TensorRT/tests/py/ts/api/test_classes.py	2026-06-22 19:49:04.913377+00:00
+++ /home/runner/work/TensorRT/TensorRT/tests/py/ts/api/test_classes.py	2026-06-22 19:49:31.041193+00:00
@@ -380,12 +380,10 @@
                io_key, "Neither 'I/O Tensors' nor 'Bindings' key is present"
            )
            self.assertTrue(
                len(trt_json["Layers"]) == num_layers
            ), "Not enough layers found"
-            self.assertTrue(
-                len(trt_json[io_key]) == 2, "Not enough I/O tensors found"
-            )
+            self.assertTrue(len(trt_json[io_key]) == 2, "Not enough I/O tensors found")


if __name__ == "__main__":
    unittest.main()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed component: api [Python] Issues re: Python API component: build system Issues re: Build system component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: core Issues re: The core compiler component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: runtime component: tests Issues re: Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant