fix: get CI to pass again#4351
Open
narendasan wants to merge 1 commit into
Open
Conversation
1ae5dc2 to
7dfdbcd
Compare
There was a problem hiding this comment.
There are some changes that do not conform to C++ style guidelines:
diff --git a/home/runner/work/TensorRT/TensorRT/core/conversion/converters/impl/conv_deconv.cpp b/tmp/changes.txt
index 83bf2b7..83b3fe7 100644
--- a/home/runner/work/TensorRT/TensorRT/core/conversion/converters/impl/conv_deconv.cpp
+++ b/tmp/changes.txt
@@ -131,8 +131,8 @@ bool add_conv_deconv(ConversionCtx* ctx, const torch::jit::Node* n, args& args)
// the constant-weights path below for why TRT requires this.
if (in->getType() != kernel->getType()) {
LOG_DEBUG(
- "Conv/deconv input type (" << in->getType() << ") differs from kernel tensor type ("
- << kernel->getType() << "); casting input to match.");
+ "Conv/deconv input type (" << in->getType() << ") differs from kernel tensor type (" << kernel->getType()
+ << "); casting input to match.");
in = castITensor(ctx, in, kernel->getType());
}
auto kernel_dims = kernel->getDimensions();
ERROR: Some files do not conform to style guidelinesThere was a problem hiding this comment.
There are some changes that do not conform to Python style guidelines:
--- /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/runtime/_runtime_config.py 2026-06-22 19:41:41.286873+00:00
+++ /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/runtime/_runtime_config.py 2026-06-22 19:42:05.507644+00:00
@@ -296,13 +296,11 @@
# already materialized the underlying IRuntimeCache on ``_live``.
wrapped = RuntimeCache(path=rc, autosave_on_del=True)
try:
wrapped.load()
except Exception as e:
- logger.warning(
- f"Failed to warm-load runtime cache from {rc!r}: {e}"
- )
+ logger.warning(f"Failed to warm-load runtime cache from {rc!r}: {e}")
cache = wrapped.ensure_cache(self._live)
self._live.set_runtime_cache(cache)
else:
raise TypeError(
f"runtime_cache must be None, str, or RuntimeCache by the "
--- /home/runner/work/TensorRT/TensorRT/tests/py/ts/api/test_classes.py 2026-06-22 19:41:41.313124+00:00
+++ /home/runner/work/TensorRT/TensorRT/tests/py/ts/api/test_classes.py 2026-06-22 19:42:11.030324+00:00
@@ -380,12 +380,10 @@
io_key, "Neither 'I/O Tensors' nor 'Bindings' key is present"
)
self.assertTrue(
len(trt_json["Layers"]) == num_layers
), "Not enough layers found"
- self.assertTrue(
- len(trt_json[io_key]) == 2, "Not enough I/O tensors found"
- )
+ self.assertTrue(len(trt_json[io_key]) == 2, "Not enough I/O tensors found")
if __name__ == "__main__":
unittest.main()7dfdbcd to
9327d19
Compare
There was a problem hiding this comment.
There are some changes that do not conform to C++ style guidelines:
diff --git a/home/runner/work/TensorRT/TensorRT/core/conversion/converters/impl/conv_deconv.cpp b/tmp/changes.txt
index 83bf2b7..83b3fe7 100644
--- a/home/runner/work/TensorRT/TensorRT/core/conversion/converters/impl/conv_deconv.cpp
+++ b/tmp/changes.txt
@@ -131,8 +131,8 @@ bool add_conv_deconv(ConversionCtx* ctx, const torch::jit::Node* n, args& args)
// the constant-weights path below for why TRT requires this.
if (in->getType() != kernel->getType()) {
LOG_DEBUG(
- "Conv/deconv input type (" << in->getType() << ") differs from kernel tensor type ("
- << kernel->getType() << "); casting input to match.");
+ "Conv/deconv input type (" << in->getType() << ") differs from kernel tensor type (" << kernel->getType()
+ << "); casting input to match.");
in = castITensor(ctx, in, kernel->getType());
}
auto kernel_dims = kernel->getDimensions();
ERROR: Some files do not conform to style guidelinesThere was a problem hiding this comment.
There are some changes that do not conform to Python style guidelines:
--- /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/runtime/_runtime_config.py 2026-06-22 19:49:04.893010+00:00
+++ /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/runtime/_runtime_config.py 2026-06-22 19:49:26.446746+00:00
@@ -296,13 +296,11 @@
# already materialized the underlying IRuntimeCache on ``_live``.
wrapped = RuntimeCache(path=rc, autosave_on_del=True)
try:
wrapped.load()
except Exception as e:
- logger.warning(
- f"Failed to warm-load runtime cache from {rc!r}: {e}"
- )
+ logger.warning(f"Failed to warm-load runtime cache from {rc!r}: {e}")
cache = wrapped.ensure_cache(self._live)
self._live.set_runtime_cache(cache)
else:
raise TypeError(
f"runtime_cache must be None, str, or RuntimeCache by the "
--- /home/runner/work/TensorRT/TensorRT/tests/py/ts/api/test_classes.py 2026-06-22 19:49:04.913377+00:00
+++ /home/runner/work/TensorRT/TensorRT/tests/py/ts/api/test_classes.py 2026-06-22 19:49:31.041193+00:00
@@ -380,12 +380,10 @@
io_key, "Neither 'I/O Tensors' nor 'Bindings' key is present"
)
self.assertTrue(
len(trt_json["Layers"]) == num_layers
), "Not enough layers found"
- self.assertTrue(
- len(trt_json[io_key]) == 2, "Not enough I/O tensors found"
- )
+ self.assertTrue(len(trt_json[io_key]) == 2, "Not enough I/O tensors found")
if __name__ == "__main__":
unittest.main()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: