Skip to content

Refactor project data to JSON#16

Open
mintyZer0 wants to merge 2 commits intopythonph:mainfrom
mintyZer0:refactor/dynamic-project-data
Open

Refactor project data to JSON#16
mintyZer0 wants to merge 2 commits intopythonph:mainfrom
mintyZer0:refactor/dynamic-project-data

Conversation

@mintyZer0
Copy link
Contributor

Fixes #11

Copy link
Collaborator

@aaroncymor aaroncymor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @mintyZer0 , I approved your PR #13 . Please pull latest changes in this branch and retain uppercases for the hex codes and DOCTYPE. To add, while not necessary, it's nice to separate the logic for opening and reading JSON file as a function and call that inside index.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor: Extract hardcoded projects list into JSON and render dynamically

2 participants