Skip to content

Migrate schedule types to Strawberry Django - #4728

Merged
patrick91 merged 3 commits into
codex/strawberry-django-keynotefrom
codex/strawberry-django-schedule
Aug 14, 2026
Merged

patrick91 merged 3 commits into
codex/strawberry-django-keynotefrom
codex/strawberry-django-schedule

Conversation

@patrick91

@patrick91 patrick91 commented Aug 13, 2026 •

Copy link
Copy Markdown
Member

No description provided.

@vercel

vercel Bot commented Aug 13, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
pycon Ready Ready Preview Aug 14, 2026 7:59am

@codecov

codecov Bot commented Aug 13, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.23009% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.74%. Comparing base (df05a0a) to head (c2f201e).

Additional details and impacted files
@@                         Coverage Diff                         @@
##           codex/strawberry-django-keynote    #4728      +/-   ##
===================================================================
+ Coverage                            92.66%   92.74%   +0.07%     
===================================================================
  Files                                  360      360              
  Lines                                11170    11210      +40     
  Branches                               895      898       +3     
===================================================================
+ Hits                                 10351    10397      +46     
+ Misses                                 696      690       -6     
  Partials                               123      123              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@claude

claude Bot commented Aug 13, 2026 •

Copy link
Copy Markdown
Contributor

Migrates the schedule/conference GraphQL types from plain strawberry.type to strawberry_django.type, delegating prefetch/select_related/annotation optimization to the Strawberry Django optimizer instead of manually building prefetch querysets in days()/talk().

No blocking issues found. One thing worth confirming with the author:

  • backend/api/schedule/types/schedule_item.py speakers(): when info.context._participants_data is empty, it now builds the participants cache by querying all schedule items for the whole conference (submission/keynote/additional speakers via subqueries) rather than just the speakers of the single item being resolved (as the old fallback did). This is fine — and clearly intentional, given the new test_schedule_capacity_query_is_constant test — for the "fetch full schedule" path where it avoids N+1 across many items, but it means a query for a single talk (e.g. conference.talk(slug)) now pulls participant rows for the entire conference instead of just that talk's speakers. test_fetch_schedule_talk still asserts only 4 queries, so round-trip count is unaffected, but result-set size for that single-talk path grows with conference size. Worth a quick sanity check that this trade-off is intended.

@patrick91
patrick91 marked this pull request as draft August 13, 2026 19:11
@patrick91
patrick91 force-pushed the codex/strawberry-django-schedule branch from 7fb63a9 to 70df062 Compare August 13, 2026 20:24
@patrick91
patrick91 changed the base branch from main to codex/strawberry-django-keynote August 13, 2026 20:24
@patrick91
patrick91 force-pushed the codex/strawberry-django-schedule branch from 70df062 to f3523f2 Compare August 13, 2026 20:48
@patrick91
patrick91 force-pushed the codex/strawberry-django-schedule branch from f3523f2 to d9f43d4 Compare August 13, 2026 21:26
@patrick91
patrick91 force-pushed the codex/strawberry-django-schedule branch from d9f43d4 to ea7bca2 Compare August 13, 2026 21:44
@patrick91
patrick91 force-pushed the codex/strawberry-django-schedule branch from ea7bca2 to ba7bf3c Compare August 13, 2026 21:57
@patrick91
patrick91 force-pushed the codex/strawberry-django-schedule branch from b9d5ae9 to c2f201e Compare August 14, 2026 07:57
@patrick91
patrick91 marked this pull request as ready for review August 14, 2026 09:21
@patrick91
patrick91 merged commit 3ed029c into main Aug 14, 2026
10 checks passed
@patrick91
patrick91 deleted the codex/strawberry-django-schedule branch August 14, 2026 09:24

This branch was successfully deployed

1 active deployment
Preview — c2f201ef Deployed Aug 14, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant