fix: hide proposal scheduled time if submission is not accepted#4584
fix: hide proposal scheduled time if submission is not accepted#4584marcoacierno merged 1 commit intomainfrom
Conversation
Only show the scheduled time and 'View Invitation' button in My Proposals when the submission status is 'accepted'. Fixes #4583 Co-authored-by: Marco Acierno <marcoacierno@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This PR changes the display logic for scheduled proposals in the My Proposals table to only show scheduled time and "View Invitation" button when the submission status is "accepted". Issues FoundLogic inconsistency: The fix prevents showing schedule information for non-accepted submissions by adding Looking at the code in my-proposals-table.tsx:82-93, the "View Invitation" button appears when
This fix would hide the schedule data in that case, which may be correct. However, it's worth verifying:
The change is a reasonable safeguard, but it's defensive coding around potentially inconsistent data. Consider whether the backend should guarantee Missing test coverage: This component has no tests. While not a blocker for this small change, the absence of tests means this behavior could regress. Consider adding at least basic smoke tests for the component. |
Fixes #4583
Only show the scheduled time and "View Invitation" button in My Proposals when the submission status is "accepted".
Generated with Claude Code