Skip to content

fix: hide proposal scheduled time if submission is not accepted#4584

Merged
marcoacierno merged 1 commit intomainfrom
claude/issue-4583-20260216-1454
Feb 16, 2026
Merged

fix: hide proposal scheduled time if submission is not accepted#4584
marcoacierno merged 1 commit intomainfrom
claude/issue-4583-20260216-1454

Conversation

@marcoacierno
Copy link
Member

Fixes #4583

Only show the scheduled time and "View Invitation" button in My Proposals when the submission status is "accepted".

Generated with Claude Code

Only show the scheduled time and 'View Invitation' button in My Proposals
when the submission status is 'accepted'.

Fixes #4583

Co-authored-by: Marco Acierno <marcoacierno@users.noreply.github.com>
@vercel
Copy link

vercel bot commented Feb 16, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
pycon Ready Ready Preview Feb 16, 2026 2:59pm

@claude
Copy link
Contributor

claude bot commented Feb 16, 2026

This PR changes the display logic for scheduled proposals in the My Proposals table to only show scheduled time and "View Invitation" button when the submission status is "accepted".

Issues Found

Logic inconsistency: The fix prevents showing schedule information for non-accepted submissions by adding isAccepted to the inSchedule condition. However, this may not fully address the underlying issue.

Looking at the code in my-proposals-table.tsx:82-93, the "View Invitation" button appears when inSchedule is true, which now requires both isAccepted and scheduleItems.length > 0. But consider this scenario:

  1. A submission is accepted and added to the schedule (scheduleItems populated)
  2. Later, the status changes to something else (e.g., "waiting_confirmation", "rejected")
  3. The scheduleItems array may still contain data from when it was accepted

This fix would hide the schedule data in that case, which may be correct. However, it's worth verifying:

  • Should scheduleItems ever be populated for non-accepted submissions on the backend?
  • If not, should the backend enforce this constraint rather than the frontend?
  • If yes, is the current logic the desired behavior?

The change is a reasonable safeguard, but it's defensive coding around potentially inconsistent data. Consider whether the backend should guarantee scheduleItems is only populated when status === 'accepted'.

Missing test coverage: This component has no tests. While not a blocker for this small change, the absence of tests means this behavior could regress. Consider adding at least basic smoke tests for the component.

@marcoacierno marcoacierno merged commit 62a0f4e into main Feb 16, 2026
7 checks passed
@marcoacierno marcoacierno deleted the claude/issue-4583-20260216-1454 branch February 16, 2026 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not show proposal scheduled time in "My proposals" if the submission status is not accepted

1 participant

Comments