Skip to content

Import Self from typing and re-enable ruff UP035 - #2998

Open
Arav-Bhandari wants to merge 1 commit into
pythonarcade:developmentfrom
Arav-Bhandari:cleanup-self-imports
Open

Arav-Bhandari wants to merge 1 commit into
pythonarcade:developmentfrom
Arav-Bhandari:cleanup-self-imports

Conversation

@Arav-Bhandari

Copy link
Copy Markdown

Self has been in the standard library since Python 3.11, which is Arcade's minimum version, so the typing_extensions imports of it are no longer needed. overload in arcade/gui/property.py moves to typing as well. override stays on typing_extensions because it needs 3.12.

Removes the temporary UP035 ignore added in 3e16859.

Closes #2985

Checked locally: make.py ruff-check, the isort and format checks, mypy and pyright all pass, and the color, camera, gui and hitbox unit tests pass. Imports only, no behavior change.

Self has been in the standard library since Python 3.11, which is
Arcade's minimum version, so the typing_extensions imports of it are
no longer needed. overload in arcade/gui/property.py moves to typing
as well. override stays on typing_extensions because it needs 3.12.

Removes the temporary UP035 ignore added in 3e16859.

Closes pythonarcade#2985

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean up imports of Self from typing_extensions

1 participant