Repository navigation
Import Self from typing and re-enable ruff UP035 - #2998
Open
Arav-Bhandari wants to merge 1 commit into
Open
Arav-Bhandari wants to merge 1 commit into
Arav-Bhandari wants to merge 1 commit into
Conversation
Self has been in the standard library since Python 3.11, which is Arcade's minimum version, so the typing_extensions imports of it are no longer needed. overload in arcade/gui/property.py moves to typing as well. override stays on typing_extensions because it needs 3.12. Removes the temporary UP035 ignore added in 3e16859. Closes pythonarcade#2985
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self has been in the standard library since Python 3.11, which is Arcade's minimum version, so the typing_extensions imports of it are no longer needed. overload in arcade/gui/property.py moves to typing as well. override stays on typing_extensions because it needs 3.12.
Removes the temporary UP035 ignore added in 3e16859.
Closes #2985
Checked locally:
make.py ruff-check, the isort and format checks, mypy and pyright all pass, and the color, camera, gui and hitbox unit tests pass. Imports only, no behavior change.