conformance: aliases_typealiastype: quote recursive aliases, and add …#1998
conformance: aliases_typealiastype: quote recursive aliases, and add …#1998erictraut merged 2 commits intopython:mainfrom
Conversation
JelleZijlstra
left a comment
There was a problem hiding this comment.
Looks good but you'll also have to update the generated results.
|
@JelleZijlstra i followed the steps in the readme regarding updating the results, it led to crashes regarding python 3.11, i attempted to debug by using python 3.11 instead and lead to other crashes i included all the updates that were generated, please advise |
8585788 to
07fae65
Compare
|
Yeah I think you need to have a 3.12 venv to run the main script, but have a 3.11 in the path in order to run pytype. I can try to run it later. |
This is caused by facebook/pyre-check#988 - pyre was broken by an upgrade of click. A new pyre version that pins the click version should be out soon; as a manual workaround, you can uninstall click-8.2.0 and install click-8.1.8. |
…an invalid case for unquoted
24f478f to
8dd72b1
Compare
i can't update these results on my machine, perhaps someone else could assist here? |
|
Thanks for the contribution. Looks good to me. |
…an invalid case for unquoted