Conformance - fix issues on Windows (unicode, Pyre)#1976
Merged
erictraut merged 2 commits intopython:mainfrom Apr 19, 2025
Andrej730:conformance-windows
Merged
Conformance - fix issues on Windows (unicode, Pyre)#1976erictraut merged 2 commits intopython:mainfrom Andrej730:conformance-windows
erictraut merged 2 commits intopython:mainfrom
Andrej730:conformance-windows
Conversation
Noticed that pyright is giving unicode output that on Windows is leading to issues generating reports later. Saving this output explicitly as unicode resolves the issue.
```python
Generating summary report
Traceback (most recent call last):
File "\typing\conformance\src\main.py", line 260, in <module>
main()
File "\typing\conformance\src\main.py", line 256, in main
generate_summary(root_dir)
File "\typing\conformance\src\reporting.py", line 19, in generate_summary
summary = template.replace("{{summary}}", generate_summary_html(root_dir))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "\typing\conformance\src\reporting.py", line 87, in generate_summary_html
results = tomli.load(f)
^^^^^^^^^^^^^
File "src\tomli\_parser.py", line 134, in load
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xa0 in position 110: invalid start byte
```
erictraut
approved these changes
Apr 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unicode error traceback: