[subprocess] Restore IO[AnyStr] on Popen stream attributes - #16204
Closed
pacocartones wants to merge 1 commit into
Closed
[subprocess] Restore IO[AnyStr] on Popen stream attributes#16204pacocartones wants to merge 1 commit into
IO[AnyStr] on Popen stream attributes#16204pacocartones wants to merge 1 commit into
Conversation
`Popen` is generic in `AnyStr`, but `stdin`, `stdout` and `stderr` were annotated as `IO[Any]`, which dropped the type parameter. Restore `IO[AnyStr]` and add a regression test case.
Contributor
|
Thank you, but existing PR already covers all needs. See |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15827
Restores
IO[AnyStr]onPopen.stdin,Popen.stdoutandPopen.stderr, which becameIO[Any]in #15654, and adds a regression test case.Agent used: Claude Opus 5 (Claude Code)