-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Made parameters of collections.abc members positional only #15305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Made parameters of collections.abc members positional only #15305
Conversation
|
I guess the failure for 3.9 will resolve itself soon: #13782 |
This comment has been minimized.
This comment has been minimized.
|
LGTM, once we drop 3.9. (I've marked this as deferred until then.) |
- Sequence - MutableSequence - AbstractSet - MutableSet - KeysView - ValuesView - ItemsView
119ce3d to
f85e9d3
Compare
|
Did a rebase to resolve conflicts (slice got updated and Additionally:
|
|
Diff from mypy_primer, showing the effect of this PR on open source code: cwltool (https://github.com/common-workflow-language/cwltool)
+ cwltool/update.py: note: In function "v1_2to1_3dev1":
+ cwltool/update.py:55:25: error: Unexpected keyword argument "index" for "pop" of "MutableSequence" [call-arg]
+ ...typeshed_to_test/stdlib/typing.pyi:698:5: note: "pop" of "MutableSequence" defined here
pydantic (https://github.com/pydantic/pydantic)
- pydantic/_internal/_model_construction.py:308: error: Incompatible types in assignment (expression has type "Callable[[Any], bool]", base class "ABCMeta" defined the type as "def __instancecheck__(cls, instance: Any) -> bool") [assignment]
- pydantic/_internal/_model_construction.py:309: error: Incompatible types in assignment (expression has type "Callable[[type], bool]", base class "ABCMeta" defined the type as "def __subclasscheck__(cls, subclass: type) -> bool") [assignment]
jax (https://github.com/google/jax)
+ jax/_src/util.py:826: error: Unused "type: ignore" comment [unused-ignore]
+ jax/_src/util.py:827: error: Unused "type: ignore" comment [unused-ignore]
|
|
nice, the __instancecheck__ = type.__instancecheck__ # pyright: ignore[reportAssignmentType]
__subclasscheck__ = type.__subclasscheck__ # pyright: ignore[reportAssignmentType] |
Fixes #14071
It doesn't seem like this will be fixed in CPython (python/cpython#135312), so we should at least fix this in the stubs to prevent false positives like this: mypy-playground
Updated methods of the following types to only accept positional-only arguments:
2026-01-20 (@srittau): Marked as deferred, until tests for 3.9 are dropped (#13782).