Repository navigation
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #508
Problem
The
fastapibenchmark (bm_fastapi) intermittently fails withhttpx.PoolTimeoutwhen the machine running the benchmark is under heavy load.The benchmark fires
CONCURRENCY = 150concurrent requests, but thehttpx.AsyncClientuses httpx's defaultmax_connections = 100. The 50 requeststhat exceed the pool size wait in the pool's queue for a connection to free up.
httpx's default pool timeout is 5 seconds, so when the in-flight requests take
longer than 5 seconds (which is exactly what happens under load), those 50 queued
requests exceed the pool timeout and the benchmark dies:
Fix
Size the connection pool to the benchmark's concurrency so that no request ever
queues:
With the pool sized to
CONCURRENCY, all 150 requests acquire a connectionimmediately, so the pool timeout can never be hit regardless of server latency.
Testing
Reproduced deterministically by serving the endpoint with an artificial ~6s
per-request delay and firing 150 concurrent requests:
httpx.PoolTimeoutafter ~5.1smax_connections=150→ completes successfully (~7.1s)No behavior change in the common case: the benchmark's concurrency is a fixed
constant, so the pool is simply sized to match it.