PEP 835: Address Discourse feedback and align better with typing spec#5027
Open
till-varoquaux wants to merge 2 commits into
Open
PEP 835: Address Discourse feedback and align better with typing spec#5027till-varoquaux wants to merge 2 commits into
till-varoquaux wants to merge 2 commits into
Conversation
Key changes: - Structure & Formatting: Reordered all sections to strictly comply with the PEP 1 template. Added a mandatory "Security Implications" section. - Terminology & Spec Alignment: Consolidated terminology to provide clear definitions for the concepts used throughout the PEP (Type Expression, Type Metadata, Non-Typing Annotation, Symbol Decorator) and align better with the typing spec. - Forward References: Clarified that `Format.TYPE` supports `None @Metadata` structurally, eliminating the need to modify `NoneType.__matmul__`. Consequently, removed the "Supporting None" open issue. - Rejected Ideas: Expanded the section to include "Alternative Syntaxes" (e.g. `<@`, soft keywords, brackets), noting their rejection due to lack of consensus. Moved the `__rmatmul__` rejection out of the Specification section. - Future Work: Added extensive examples of how the syntax might map to future Symbol Decorators, and added a JSR 308-inspired proposal for PEP 746 target-based constraints using intersection types (`&`).
Documentation build overview
|
Contributor
Author
|
@JelleZijlstra thanks for the feedback. Removed @erictraut: I borrowed your process-of-elimination logic for the "Why the @ Operator?" section. Thank you so much. |
till-varoquaux
force-pushed
the
feature/pep-835-update
branch
4 times, most recently
from
b644885 to
9ef1934
Compare
ilevkivskyi
reviewed
Jul 10, 2026
ilevkivskyi
left a comment
ilevkivskyi
left a comment
Member
There was a problem hiding this comment.
LG, thanks, I have few random comments.
|
|
||
| Using ``@`` might confuse users expecting matrix multiplication. Within a type | ||
| expression, Python intentionally reuses standard operators (like ``|`` and | ||
| ``[]``) with typing-specific semantics. |
Member
There was a problem hiding this comment.
I am not sure what this rejected idea means.
| Writing ``address: (str | None) @Field(...)`` adds verbosity due to the lack | ||
| of native symbol decorators. Frameworks co-opt ``Annotated`` to configure | ||
| fields, even though the developer's intent is to configure the ``address`` | ||
| field, not the ``str | None`` type. |
Member
There was a problem hiding this comment.
This section feels unresolved. You should add some kind of conclusion here.
| expression, Python intentionally reuses standard operators (like ``|`` and | ||
| ``[]``) with typing-specific semantics. | ||
|
|
||
| Format.TYPE and ``@`` in type hints |
Member
There was a problem hiding this comment.
This section title is unclear as well. It should be formulated as a very short description of a thing being rejected.
till-varoquaux
force-pushed
the
feature/pep-835-update
branch
from
9ef1934 to
b444c9e
Compare
till-varoquaux
force-pushed
the
feature/pep-835-update
branch
from
b444c9e to
a417416
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key changes:
Format.TYPEsupportsNone @Metadatastructurally, eliminating the need to modifyNoneType.__matmul__. Consequently, removed the "Supporting None" open issue.<@, soft keywords, brackets), noting their rejection due to lack of consensus. Moved the__rmatmul__rejection out of the Specification section.&).PEP 123: Summary of changes)