Optimize: skip logging and stats collection calls if they are no-ops#20839
Merged
Optimize: skip logging and stats collection calls if they are no-ops#20839
Conversation
We had lots of logging that was fairly expensive even if disabled, since just calling the functions or constructing the log messages was slow. Now put some of the most expensive logging calls behind fast bool flag checks.
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
ilevkivskyi
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had lots of logging that was fairly expensive even if disabled, since
just calling the functions or constructing the log messages adds overhead,
and calling
time.time()to collect timings has a cost. Now put some of themost expensive logging/stats calls behind fast bool flag checks.
Based on CPU profiles, this should improve performance of mostly cached
incremental runs if they are big enough by at least 2%, but potentially by
even more (hard to predict).