Enhance cache determinism and implement error serialization for remote workers#20835
Open
lshariprasad wants to merge 5 commits intopython:masterfrom
Open
Enhance cache determinism and implement error serialization for remote workers#20835lshariprasad wants to merge 5 commits intopython:masterfrom
lshariprasad wants to merge 5 commits intopython:masterfrom
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves distributed build efficiency by standardizing cache outputs and enabling cross-process error replaying.
To-Do / Progress List
[x] Normalize Cache Metadata: Zero out mtimes and sort dependencies to ensure deterministic cache hashes.
[x] Implement Error Serialization: Added read/write methods to ErrorInfo for transmitting errors between worker and coordinator.
[x] Sync Parallel Workers: Updated worker protocol to replay import errors and maintain state consistency.
[x] Update Node Serialization: Fixed binary serialization for FuncDef and Var flags (e.g., is_generator, is_final).
[x] Refine Parser & MyPyC: Switched C-string encoding to hex and fixed module-level type: ignore logic.
![Uploading 1.png…]()