Don't create .mypy_cache directory when --no-incremental is used#20833
Open
Fridayai700 wants to merge 1 commit intopython:masterfrom
Open
Don't create .mypy_cache directory when --no-incremental is used#20833Fridayai700 wants to merge 1 commit intopython:masterfrom
Fridayai700 wants to merge 1 commit intopython:masterfrom
Conversation
When running mypy with --no-incremental, the .mypy_cache directory was still being created. This happened because the metadata store was initialized unconditionally, and the filesystem/sqlite stores create the cache directory during initialization or on first write. The fix creates a no-op FilesystemMetadataStore backed by os.devnull when incremental mode is disabled, which prevents any cache directory creation or file writes. Both FilesystemMetadataStore and SqliteMetadataStore already handle os.devnull as a no-op case, so this approach is consistent with the existing --cache-dir=/dev/null behavior. Fixes python#19489
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When running mypy with
--no-incremental, the.mypy_cachedirectory is still created, even though the help text implies it won't be:Root cause
The metadata store (which manages the cache directory) is initialized unconditionally in
BuildManager.__init__(). While thecache_enabledflag prevents cache reads, the store still creates the cache directory on init (for SQLite stores) or on first write (for filesystem stores).Fix
When
options.incrementalis False,create_metastore()now returns a no-opFilesystemMetadataStorebacked byos.devnull. Both store implementations already handleos.devnullas a no-op — this is the same behavior users get with--cache-dir /dev/null, which was the documented workaround.After:
Test plan
--no-incrementalno longer creates.mypy_cachepython -m pytest mypy/test/testcheck.py -k "testNoIncremental or testIncremental" -o "addopts="— all passFixes #19489