-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
fix detection of whether MemberExpr.expr represents self/cls in…
#20480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bzoracler
wants to merge
1
commit into
python:master
Choose a base branch
from
bzoracler:fix-20479
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+52
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzoracler
commented
Dec 27, 2025
Comment on lines
+8331
to
+8361
| [case testClassScopeImportAccessibleInMethods] | ||
| class A: | ||
| import mod | ||
| from mod import var | ||
|
|
||
| def __new__(cls) -> "A": | ||
| reveal_type(cls.mod) # N: Revealed type is "types.ModuleType" | ||
| reveal_type(cls.var) # N: Revealed type is "builtins.int" | ||
| reveal_type(cls.mod.var) # N: Revealed type is "builtins.int" | ||
| return cls() | ||
|
|
||
| def pos_or_named_self(self) -> None: | ||
| reveal_type(self.mod) # N: Revealed type is "types.ModuleType" | ||
| reveal_type(self.var) # N: Revealed type is "builtins.int" | ||
| reveal_type(self.mod.var) # N: Revealed type is "builtins.int" | ||
|
|
||
| def pos_only_self(self, /) -> None: | ||
| reveal_type(self.mod) # N: Revealed type is "types.ModuleType" | ||
| reveal_type(self.var) # N: Revealed type is "builtins.int" | ||
| reveal_type(self.mod.var) # N: Revealed type is "builtins.int" | ||
|
|
||
| @classmethod | ||
| def clsmethod(cls) -> None: | ||
| reveal_type(cls.mod) # N: Revealed type is "types.ModuleType" | ||
| reveal_type(cls.var) # N: Revealed type is "builtins.int" | ||
| reveal_type(cls.mod.var) # N: Revealed type is "builtins.int" | ||
|
|
||
| [file mod.py] | ||
| var = 1 | ||
| [builtins fixtures/module.pyi] | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.mod.var was revealed to be Any in the body of __new__() and pos_only_self() before this PR. See e.g. mypy Playground for a reproducer:
class A:
import math
def __new__(cls) -> "A":
reveal_type(cls.math.pi) # N: Revealed type is "Any"
return cls()
def pos_or_named_self(self) -> None:
reveal_type(self.math.pi) # N: Revealed type is "builtins.float"
def pos_only_self(self, /) -> None:
reveal_type(self.math.pi) # N: Revealed type is "Any"
@classmethod
def clsmethod(cls) -> None:
reveal_type(cls.math.pi) # N: Revealed type is "builtins.float"
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…side methods
Fixes #20479.