Skip to content

[3.14] gh-159184: Do not intern NaN constants on the free-threaded build (GH-161276) #161286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
miss-islington wants to merge 1 commit into
base: 3.14
Choose a base branch
from
+12 −2
Open

[3.14] gh-159184: Do not intern NaN constants on the free-threaded build (GH-161276) #161286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Core_and_Builtins/2026-11-03-13-44-26.gh-issue-159184.X_sOdY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix a leak of NaN constants in code objects created by :func:`marshal.loads`
on the free-threaded build.
12 changes: 10 additions & 2 deletions Objects/codeobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,16 @@ should_immortalize_constant(PyObject *v)
_Py_IsImmortal(slice->stop) &&
_Py_IsImmortal(slice->step));
}
return (PyLong_CheckExact(v) || PyFloat_CheckExact(v) ||
PyComplex_CheckExact(v) || PyBytes_CheckExact(v));
// The hash of a NaN depends on its address, so the table would keep every
// NaN object it gets (and merging them would shrink frozensets).
if (PyFloat_CheckExact(v)) {
return !isnan(PyFloat_AS_DOUBLE(v));
}
if (PyComplex_CheckExact(v)) {
Py_complex c = ((PyComplexObject *)v)->cval;
return !isnan(c.real) && !isnan(c.imag);
}
return PyLong_CheckExact(v) || PyBytes_CheckExact(v);
}
#endif

Expand Down
Loading