Repository navigation
gh-161108: Make configparser clear() linear time - #161109
Merged
Merged
Conversation
Give SectionProxy its own popitem() and clear() and RawConfigParser its own clear() instead of the MutableMapping ones, which copied every remaining key for each removal.
gpshead
added
needs backport to 3.14
gpshead
marked this pull request as ready for review
November 1, 2026 18:29
gpshead
enabled auto-merge (squash)
November 1, 2026 18:29
|
Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
|
GH-161133 is a backport of this pull request to the 3.14 branch. |
|
GH-161134 is a backport of this pull request to the 3.15 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Give
SectionProxyits ownpopitem()andclear(), andRawConfigParserits ownclear(), so they take the keys from the underlying dicts once instead of copying every remaining key on each removal.RawConfigParser.clear()still goes throughdel self[section], so subclass__delitem__()overrides keep running. This also fixes two oddities of the inheritedMutableMappingmethods:section.clear()no longer fails part way withInterpolationErroron a value it is removing, andsection.popitem()on a section with only DEFAULT options left raisesKeyErrorwithout naming a DEFAULT option it could not remove.Fixes #161108
ANT-2026-FWT5DX83
configparserclear()on a section or parser takes quadratic time #161108