[deadlovelll]

Fix missing statistics in heatmap replay output

For details see gh-161008

[maurycy]

The with_stats=False branch doesn't assert anything.

Maybe we could assert what we expect for a file without the stats extension? I think that here it'd be 0.0 sec, 0.0, N/A, N/A. If that's the case, do we want to show 0.0 sec for old files, instead of N/A?

[maurycy]

This is a verbatim copy of

cpython/Lib/profiling/sampling/stack_collector.py

Lines 155 to 167 in 1259f16

	def set_replay_stats(self, info):
	"""Restore measured statistics stored in a binary profile."""
	duration_sec = info.get("duration_sec")
	sample_rate = info.get("sample_rate")
	if duration_sec is None or sample_rate is None:
	return
	self.set_stats(
	self.sample_interval_usec,
	duration_sec,
	sample_rate,
	error_rate=info.get("error_rate"),
	missed_samples=info.get("missed_samples"),
	mode=self.stats.get("mode"),

I wonder how we can avoid this?

There's an interesting disprepancy:

cpython/Lib/profiling/sampling/cli.py

Lines 796 to 799 in 1259f16

	if hasattr(collector, "set_replay_stats"):
	collector.set_replay_stats(info)
	if hasattr(collector, "set_mode"):
	collector.set_mode(info.get("mode"))

cpython/Lib/profiling/sampling/sample.py

Lines 244 to 245 in 1259f16

	if hasattr(collector, 'set_stats'):
	collector.set_stats(self.sample_interval_usec, running_time_sec, sample_rate, error_rate, missed_samples, mode=self.mode)

[deadlovelll]

Thanks for the review! I’ve taken all your comments into account, and it’s true that I didn’t quite finish writing the test...