Skip to content

gh-160931: Speed up bytes construction from exact bytes and int #160934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cmaloney wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −2
Open

gh-160931: Speed up bytes construction from exact bytes and int #160934

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c2bb06
gh-160931: Speed up bytes construction from exact bytes and int
cmaloney Oct 28, 2026
6805424
Remove NEWS
cmaloney Oct 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions Objects/bytesobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2970,10 +2970,16 @@ bytes_new_impl(PyTypeObject *type, PyObject *x, const char *encoding,
"errors without a string argument");
return NULL;
}
/* bytes is immutable and bytes.__bytes__() returns an exact bytes
unchanged, so skip the lookup and the call. */
else if (PyBytes_CheckExact(x)) {
bytes = Py_NewRef(x);
}
/* We'd like to call PyObject_Bytes here, but we need to check for an
integer argument before deferring to PyBytes_FromObject, something
PyObject_Bytes doesn't do. */
else if ((func = _PyObject_LookupSpecial(x, &_Py_ID(__bytes__))) != NULL) {
PyObject_Bytes doesn't do. int is immutable and has no __bytes__. */
else if (!PyLong_CheckExact(x) &&
(func = _PyObject_LookupSpecial(x, &_Py_ID(__bytes__))) != NULL) {
bytes = _PyObject_CallNoArgs(func);
Py_DECREF(func);
if (bytes == NULL)
Expand Down
Loading