Skip to content

gh-160858: Use the list freelist in list() #160859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
corona10 merged 2 commits into from
Oct 29, 2026
+5 −2
Merged

gh-160858: Use the list freelist in list() #160859

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4e4427
gh-160858: Use the list freelist in list()
cmaloney Oct 28, 2026
04bd070
Remove NEWS
cmaloney Oct 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions Objects/listobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3600,7 +3600,7 @@ static int
list___init___impl(PyListObject *self, PyObject *iterable)
/*[clinic end generated code: output=0f3c21379d01de48 input=b3f3fe7206af8f6b]*/
{
/* Verify list invariants established by PyType_GenericAlloc() */
/* Verify list invariants */
assert(0 <= Py_SIZE(self));
assert(Py_SIZE(self) <= self->allocated || self->allocated == -1);
assert(self->ob_item != NULL ||
Expand Down Expand Up @@ -3632,7 +3632,10 @@ list_vectorcall(PyObject *type, PyObject * const*args,
return NULL;
}

PyObject *list = PyType_GenericAlloc(_PyType_CAST(type), 0);
/* use PyList_New() to make exact lists from the freelist. */
PyObject *list = (type == (PyObject *)&PyList_Type

@cmaloney cmaloney Oct 29, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should always be true because tp_vectorcall is not inherited but with the handwritten vector call, it isn't asserted in debug builds

? PyList_New(0)
: PyType_GenericAlloc(_PyType_CAST(type), 0));
if (list == NULL) {
return NULL;
}
Expand Down
Loading