Skip to content

[3.14] gh-56689 test case to cover for windows proxy_bypass misbehaving trailing ; entries on windows. (GH-160841) #160845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
orsenthil merged 1 commit into from
Oct 28, 2026
Merged

[3.14] gh-56689 test case to cover for windows proxy_bypass misbehaving trailing ; entries on windows. (GH-160841) #160845

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions Lib/test/test_urllib2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1608,6 +1608,14 @@ def test_winreg_proxy_bypass(self):
"expect <local> to bypass intranet address '%s'"
% host)

# empty entries (e.g. a trailing ';') must not match every host
for proxy_override in ("www.example.com;", ";", " ; ",
"www.example.com;;*.example.net"):
self.assertFalse(proxy_bypass("www.python.org", proxy_override),
"expected empty entry in %r not to bypass"
% proxy_override)
self.assertTrue(proxy_bypass("www.example.com", "www.example.com;"))

@unittest.skipUnless(sys.platform == 'darwin', "only relevant for OSX")
def test_osx_proxy_bypass(self):
bypass = {
Expand Down
Loading