Repository navigation
gh-160773: Fix use-after-free in OSError.__str__ - #160822
Merged
Merged
Conversation
|
All commit authors signed the Contributor License Agreement. |
StanFromIreland
approved these changes
Oct 29, 2026
StanFromIreland
added
needs backport to 3.14
StanFromIreland
enabled auto-merge (squash)
October 29, 2026 10:50
|
Thanks @alonfaraj for the PR, and @StanFromIreland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
|
GH-160884 is a backport of this pull request to the 3.15 branch. |
|
GH-160885 is a backport of this pull request to the 3.14 branch. |
Member
|
Merged, thanks! |
StanFromIreland
added a commit
that referenced
this pull request
Oct 29, 2026
StanFromIreland
added a commit
that referenced
this pull request
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #160773
OSError.__str__passed borrowed references to its attributes (errno,strerror,filename,filename2, andwinerroron Windows) toPyUnicode_FromFormat. Formatting one attribute with%S/%Rcan run arbitrary Python code. If that code modifies another attribute, the object being formatted can be freed while still in use.The fix now take strong references to the attributes before formatting and release them afterwards.
Added a regression test which cover the
filenameandfilename -> filename2formats.Tested on linux (Ubuntu 26.04).
OSError.__str__when a formatting callback clearsfilename#160773