Repository navigation
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Conversion can destroy a borrowed stream before it is used, and delaying the write lookup changes observable behavior.
2 open issues
What changed in this PR
This PR simplifies CPython’s PyFile_WriteObject() and aims to reduce write-call overhead by avoiding bound-method allocation.
Changes:
- Replaces explicit
writeattribute lookup and invocation withPyObject_CallMethodOneArg(). - Simplifies string conversion and removes writer-reference cleanup.
| File | Description |
|---|---|
Objects/fileobject.c |
Streamlines value conversion and the write call in PyFile_WriteObject(). |
Review effort: Balanced
| else | ||
| value = PyObject_Repr(v); | ||
|
|
||
| PyObject *value = (flags & Py_PRINT_RAW) ? PyObject_Str(v) : PyObject_Repr(v); |
| return -1; | ||
| } | ||
| result = PyObject_CallOneArg(writer, value); | ||
| PyObject *result = PyObject_CallMethodOneArg(f, &_Py_ID(write), value); |
methane
force-pushed
the
codex/file-writeobject-vectorcall
branch
from
October 28, 2026 07:15
d7498af to
a026992
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simplifies the implementation of
PyFile_WriteObject()while also improving its performance.ref: #160727 (comment)