Repository navigation
gh-60299: Fix ProxyDigestAuthHandler credential lookup to use proxy authority - #160528
Merged
Merged
Conversation
…roxy authority AbstractDigestAuthHandler.get_authorization() always looked up credentials using the target request URL (req.full_url), even when invoked via ProxyDigestAuthHandler, whose credentials are registered against the proxy's host:port. The lookup never matched, no Proxy-Authorization header was produced, and proxy digest auth failed with an unhandled 407. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Fix urllib2_localnet test cases.
orsenthil
added
needs backport to 3.14
|
Thanks @orsenthil for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
|
GH-160914 is a backport of this pull request to the 3.15 branch. |
|
GH-160915 is a backport of this pull request to the 3.14 branch. |
orsenthil
added a commit
that referenced
this pull request
Oct 29, 2026
…proxy authority (GH-160528) (#160914) gh-60299: Fix ProxyDigestAuthHandler credential lookup to use proxy authority (GH-160528) AbstractDigestAuthHandler.get_authorization() always looked up credentials using the target request URL (req.full_url), even when invoked via ProxyDigestAuthHandler, whose credentials are registered against the proxy's host:port. The lookup never matched, no Proxy-Authorization header was produced, and proxy digest auth failed with an unhandled 407. (cherry picked from commit 9b3e095) Co-authored-by: Senthil Kumaran <senthil@python.org> Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
orsenthil
added a commit
that referenced
this pull request
Oct 29, 2026
…proxy authority (GH-160528) (#160915) gh-60299: Fix ProxyDigestAuthHandler credential lookup to use proxy authority (GH-160528) AbstractDigestAuthHandler.get_authorization() always looked up credentials using the target request URL (req.full_url), even when invoked via ProxyDigestAuthHandler, whose credentials are registered against the proxy's host:port. The lookup never matched, no Proxy-Authorization header was produced, and proxy digest auth failed with an unhandled 407. (cherry picked from commit 9b3e095) Co-authored-by: Senthil Kumaran <senthil@python.org> Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AbstractDigestAuthHandler.get_authorization() always looked up credentials using the target request URL (req.full_url), even when invoked via ProxyDigestAuthHandler, whose credentials are registered against the proxy's host:port. The lookup never matched, no Proxy-Authorization header was produced, and proxy digest auth always failed with an unhandled 407.
Match ProxyBasicAuthHandler/HTTPBasicAuthHandler: use the proxy's authority (req.host) for the proxy case, and keep using the full URL for ordinary (non-proxy) digest auth so HTTPPasswordMgr's sub-URI realm matching keeps working.
Fixes #60299
test_proxy_digest_auth, which fails on currentmainand passes with this fix.test_digest_auth_uses_full_urlas a regression guard for the non-proxy path.