Repository navigation
gh-160522: Restore CJK encoder state after a failed incremental encode - #160523
Merged
Merged
Conversation
… encode A failed IncrementalEncoder.encode() or StreamWriter.write() of a stateful CJK codec kept the shift state reached before the error although its output was discarded.
gpshead
added
needs backport to 3.14
gpshead
marked this pull request as ready for review
October 23, 2026 22:05
|
Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
|
GH-161000 is a backport of this pull request to the 3.15 branch. |
|
GH-161001 is a backport of this pull request to the 3.14 branch. |
gpshead
added a commit
that referenced
this pull request
Oct 31, 2026
…l encode (GH-160523) (#161001) gh-160522: Restore CJK encoder state after a failed incremental encode (GH-160523) A failed IncrementalEncoder.encode() or StreamWriter.write() of a stateful CJK codec kept the shift state reached before the error although its output was discarded. (cherry picked from commit 5b25582) Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com>
gpshead
added a commit
that referenced
this pull request
Oct 31, 2026
…l encode (GH-160523) (#161000) gh-160522: Restore CJK encoder state after a failed incremental encode (GH-160523) A failed IncrementalEncoder.encode() or StreamWriter.write() of a stateful CJK codec kept the shift state reached before the error although its output was discarded. (cherry picked from commit 5b25582) Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
encoder_encode_stateful()now saves the codec state on entry and puts it back when the call fails, as it already did for its pending buffer. A failed call discards its output, so keeping the state it reached made the nextIncrementalEncoder.encode()orStreamWriter.write()skip the escape sequence. The decoders are not changed: they keep the state reached before the error, which is right for a caller that goes on with the following bytes of the same stream.Fixes #160522
ANT-2026-ZDF903IU
encode()#160522