Repository navigation
gh-160187: Reject ISO-2022 designations into the wrong G set - #160188
Merged
Merged
Conversation
The ISO-2022 decoders checked only that a designated charset belonged to the encoding, not that it went to the code element the encoding assigns it to.
gpshead
force-pushed
the
iso2022-wrong-g-set
branch
from
October 22, 2026 04:45
65399ab to
7c83abe
Compare
gpshead
enabled auto-merge (squash)
November 1, 2026 06:05
gpshead
disabled auto-merge
November 1, 2026 06:05
gpshead
enabled auto-merge (squash)
November 1, 2026 06:05
|
Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15. |
|
GH-161064 is a backport of this pull request to the 3.15 branch. |
|
gpshead
added a commit
that referenced
this pull request
Nov 1, 2026
…H-160188) (#161064) gh-160187: Reject ISO-2022 designations into the wrong G set (GH-160188) The ISO-2022 decoders checked only that a designated charset belonged to the encoding, not that it went to the code element the encoding assigns it to. ANT-2026-TH3IZKXQ (cherry picked from commit 5f28e31) Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iso2022processesc()now requires the designation table entry's plane to match the G set the escape designates to, and accepts ASCII only for G0. Conforming encoders (including ours) never emit the escapes this rejects, but strict decoding of such malformed data now raisesUnicodeDecodeErrorwhere it used to return wrong text.The
RuntimeErroralone could be fixed in maintenance branches by havingiso2022processg2()return an ordinary decode error instead ofMBERR_INTERNAL.Fixes #160187
ANT-2026-TH3IZKXQ