gh-157519: Don't defer deallocation on an unknown stack - #157520
Open
JamesWrigley wants to merge 1 commit into
Open
JamesWrigley wants to merge 1 commit into
JamesWrigley wants to merge 1 commit into
Conversation
`_Py_RecursionLimit_GetMargin()` now reports plenty of margin when the stack pointer is far outside the stack limits, the same rule `_Py_CheckRecursiveCall()` uses to detect stack switching. Previously `_Py_Dealloc()` deferred every GC object to the trash queue on such a stack and the chain was never destroyed.
JamesWrigley
requested review from
FFY00,
ZeroIntensity and
ericsnowcurrently
as code owners
September 14, 2026 19:36
|
All commit authors signed the Contributor License Agreement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_Py_RecursionLimit_GetMargin()now reports plenty of margin when the stack pointer is far outside the stack limits, the same rule_Py_CheckRecursiveCall()uses to detect stack switching. Previously_Py_Dealloc()deferred every GC object to the trash queue on such a stack and the objects were never freed.Fixes #157519. Output of the MWE on my machine:
Written with help from Claude 🤖 Though I reviewed and tested all the changes myself. I think this should be backported to 3.14?
_Py_Dealloc()being unaware of separate stacks can cause memory leaks #157519